[LU-766] Incorrect HAVE_STATFS_DENTRY_PARAM result

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0, Lustre 2.1.0, Lustre 1.8.6
• Fix Version/s: Lustre 2.2.0
• Type: Bug
• Priority: Minor
• Reporter: Brian Behlendorf
• Assignee: Yang Sheng
• Resolution: Fixed

Environment

RHEL6.2 BETA, kernel-2.6.32-204

• Story Points: 1
• Severity: 3
• Epic: server

Description

Building with RHEL6.2 beta (kernel-2.6.32-204) exposed that the
HAVE_STATFS_DENTRY_PARAM autoconf check was incorrect. The test
was setup to check the first argument of vfs_statfs() function.
However, the conditional code itself doesn't use the vfs_statfs()
function it registers a function with the sops->statfs() callback.

Historically, this always worked because both of these prototypes
were changed in a single upstream kernel commit (726c3342). However,
as of RHEL6.2 the vfs_statfs() function changed again and the
sops->statfs() callback stayed the same. The vfs_statfs() function
now takes a path structure as the first parameter.

This was fixed by simply updating the autoconf test to check the
prototype of the function were going to actually use.

Comments

[Brian Behlendorf]

http://review.whamcloud.com/1527

[Oleg Drokin]

Assigning to Yang Sheng to take a look

[Peter Jones]

Has anyone from LLNL looked at YangSheng's revised patch - http://review.whamcloud.com/#change,1527 ?

[Christopher Morrone]

It is probably fine, but we are still using our original patch. Haven't had a chance to try that version.

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = FAILURE
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Peter Jones]

Landed for 2.2

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #388
LU-766 Fix sops->statfs() autoconf check (Revision befe9c673b23ef4f776615d9a6de12ad8b65bbcf)

Result = SUCCESS
Oleg Drokin : befe9c673b23ef4f776615d9a6de12ad8b65bbcf
Files :

• lustre/autoconf/lustre-core.m4