[LU-7666] llog_cat_new_log() should use chunk size when freeing header Created: 14/Jan/16  Updated: 27/Jan/16  Resolved: 27/Jan/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: llog

Issue Links:
Related
is related to LU-6602 ASSERTION( rec->lrh_len <= 8192 ) failed Resolved
is related to LU-6587 refactor OBD_ALLOC_LARGE to always do... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In llog_cat_new_log() we create a spurious memory leak warning when we use OBD_FREE_PTR(loghandle->lgh_hdr) rather than OBD_FREE(..., loghandle->lgh_ctxt->loc_chunk_size).

From leak_finder.pl:

*** Free different size (32768 alloced, 8192 freed).
    malloc at llog.c:llog_init_handle:345, free at llog_cat.c:llog_cat_new_log:104


 Comments   
Comment by Joseph Gmitter (Inactive) [ 14/Jan/16 ]

Assigning to John as he is planning to push the patch.

Comment by Gerrit Updater [ 14/Jan/16 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/18009
Subject: LU-7666 llog: use correct size when freeing log header
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: afe98c8874de48c4cc308fcef5ec369c1e871bb5

Comment by Andreas Dilger [ 18/Jan/16 ]

This problem was introduced in http://review.whamcloud.com/14883 "LU-6602 obdclass: variable llog chunk size".

Comment by Gerrit Updater [ 26/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18009/
Subject: LU-7666 llog: use correct size when freeing log header
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2b9ac5ce6399f1cec82a772c05aa64fec15b7112

Comment by Joseph Gmitter (Inactive) [ 27/Jan/16 ]

Landed for 2.8.0

Generated at Sat Feb 10 02:10:53 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.