[LU-7877] Suspect locking cleanup in mdt_reint_rename_internal() Created: 14/Mar/16 Updated: 14/Jan/18 Resolved: 14/Jan/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oleg Drokin | Assignee: | Lai Siyao |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
In mdt_reint_rename_internal():
rc = mdt_reint_object_lock(info, mold, lh_oldp, lock_ibits,
cos_incompat);
if (rc != 0)
GOTO(out_unlock_old, rc);
...
rc = mdt_reint_object_lock(info, mold, lh_oldp, lock_ibits,
cos_incompat);
if (rc != 0)
GOTO(out_unlock_old, rc);
...
out_unlock_old:
mdt_object_unlock(info, mold, lh_oldp, rc);
out_put_new:
if (mnew != NULL)
mdt_object_put(info->mti_env, mnew);
I guess both of those GOTOs should go to out_put_new? |
| Comments |
| Comment by Peter Jones [ 14/Dec/17 ] |
|
Lai Can you please look into this one? Peter |
| Comment by Lai Siyao [ 03/Jan/18 ] |
|
please refer to |