[LU-7899] osd_xattr_set() to batch actual EA update

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.10.1, Lustre 2.11.0
• Type: Improvement
• Priority: Minor
• Reporter: Alex Zhuravlev
• Assignee: Alex Zhuravlev
• Resolution: Fixed

Description

moving EAs from nvlist into bonus/spill is quite expensive, we can save on this a bit collecting changes in nvlist (what we do already) and calling sa_update() from osd_trans_stop().

Issue Links

• is blocking: LU-7895 zfs metadata performance improvements
• is related to: LU-8449 OSS crash with oom-killer started

Comments

[Gerrit Updater]

Alex Zhuravlev ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19143
Subject: LU-7899 osd: batch EA updates
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 64ecfcbf26bdb21362adb91c62967a9b7db50faf

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19143/
Subject: LU-7899 osd: batch EA updates
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6cd79ab5860c59c2a640a9e8ca4ee86eec050b43

[Joseph Gmitter (Inactive)]

Patch has landed to master for 2.9.0

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21878
Subject: Revert "LU-7899 osd: batch EA updates"
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9e26d30328dbe8bd01740ed9981b3a9ce62a4af0

[Cliff White (Inactive)]

Testing on soak - no longer having soft lockups.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/21878/
Subject: Revert "LU-7899 osd: batch EA updates"
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6fad3abf6f962d04989422cb44dfb7aa0835ad07

[Peter Jones]

Oleg has reverted this change

[Gerrit Updater]

Alex Zhuravlev ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21893
Subject: LU-7899 osd: batch EA updates
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5cf0af5604a1eed3121d82d90ede98eb6207f3c7

[Cliff White (Inactive)]

Soak testing started: 2017-05-24 21:29:31

[Cliff White (Inactive)]

Immediately hit LU-9504. Have to roll up multiple fixes to get a possible working build, will work on that Friday.

[Alex Zhuravlev]

thanks... working on that.

[Alex Zhuravlev]

hmm, I still can't reproduce it Cliff, is it possible to run with just this patch and watch slabtop output along the run?

[Cliff White (Inactive)]

We need a decent working baseline to apply this patch too. That is the problem. LU-9504 currently kills the system too quickly, we must have a fix for that in the baseline.

[Cliff White (Inactive)]

Since we have landed LU-9504, can this patch be rebased? I will be able to run it on soak.

[Alex Zhuravlev]

Cliff, the patch has been rebased. please, give it a run. thanks in advance.

[Cliff White (Inactive)]

I am seeing more odd job failures. Things like:

07/21/2017 19:10:37: Process 0(soak-16.spirit.hpdd.intel.com): FAILED in mdtest_stat, unable to stat file: Input/output error
34395-simul.out:19:32:08: Process 10(soak-26.spirit.hpdd.intel.com): FAILED in simul_file_stat, stat failed: Input/output error
34409-simul.out:19:31:50: Process 12(soak-26.spirit.hpdd.intel.com): FAILED in simul_truncate, truncate failed: Cannot send after transport endpoint shutdown
34442-simul.out:19:10:37: Process 0(soak-16.spirit.hpdd.intel.com): FAILED in create_files, write in file /mnt/soaked/soaktest/test/simul/34442/simul_write.12: Input/output error
34454-mdtestssf.out:07/21/2017 19:10:37: Process 0(soak-16.spirit.hpdd.intel.com): FAILED in mdtest_stat, unable to stat file: Input/output error
34454-mdtestssf.out:07/21/2017 19:10:37: Process 1(soak-16.spirit.hpdd.intel.com): FAILED in mdtest_stat, unable to stat file: Input/output error
34462-simul.out:19:25:28: Process 26(soak-29.spirit.hpdd.intel.com): FAILED in simul_truncate, truncate failed: Input/output error

investigating.

[Cliff White (Inactive)]

With this patch, i am seeing more jobs fail than succeed.

[Alex Zhuravlev]

Cliff, any more details?

[Cliff White (Inactive)]

What are you looking for from slab top? No hard crashes yet, restarting this morning.

[Cliff White (Inactive)]

Tested latest version of the patch, ran 24 hours on soak, so far. No significant errors.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/21893/
Subject: LU-7899 osd: batch EA updates
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2c9ff6dffdf4320af95c9db9af07a416529275f0

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28482
Subject: LU-7899 osd: batch EA updates
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 214a6c3d66456ff5f73fce8eb06b0b8e164347f7

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/28482/
Subject: LU-7899 osd: batch EA updates
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: d53a1183058ebfd52bf61b194d151369ba7c5087