[LU-790] "patchless_client" is hard-coded as Lustre kernel version Created: 25/Oct/11 Updated: 31/Jul/16 Resolved: 26/May/15 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.1.0, Lustre 1.8.6 |
| Fix Version/s: | Lustre 2.8.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Jian Yu | Assignee: | Andreas Dilger |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||
| Severity: | 3 | ||||
| Rank (Obsolete): | 7590 | ||||
| Description |
|
After I set up a Lustre server and ran "lctl get_param -n version", I got: [root@fat-intel-2 ~]# uname -a Linux fat-intel-2.lab.whamcloud.com 2.6.18-238.19.1.el5_lustre.g42758c3 #1 SMP Wed Oct 5 21:19:10 PDT 2011 x86_64 x86_64 x86_64 GNU/Linux [root@fat-intel-2 ~]# lctl get_param -n version lustre: 2.1.50 kernel: patchless_client build: jenkins-gb05ed4f-PRISTINE-2.6.18-238.19.1.el5_lustre.g42758c3 The node is not a patchless Lustre client, but the above command showed "kernel: patchless_client", which is confusable. The "patchless_client" string is hard-coded in obd_proc_read_version() as Lustre kernel version without doing some checks. |
| Comments |
| Comment by Andreas Dilger [ 25/Oct/11 ] |
|
This is as it is for historical reasons. "patchless_client" means that the client does not use any VFS patches, as were needed in the past. The earlier clients would report a numeric value here, as reported in lustre/kernel_patches/patches/lustre_version.h, depending on what kernel patches were applied. Since all Lustre clients are now patchless, the "patchless_client" string has relatively little use, and could be removed. It would also be useful to delete the lines in lustre/tests/sanity.sh that are using check_kernel_version(), since those checks will always be true today. Care should be taken with test_51b() which uses this check to set a default parameter. The comment there seems to be old and useless, since the test has been running with NUMTEST=31000 for a long time. |
| Comment by Manisha salve (Inactive) [ 08/Apr/13 ] |
|
The changes to remove "patchless_client" string will be committed under |
| Comment by Gerrit Updater [ 28/Apr/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/4173/ |
| Comment by Gerrit Updater [ 11/May/15 ] |
|
Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/14768 |
| Comment by Gerrit Updater [ 26/May/15 ] |
|
Andreas Dilger (andreas.dilger@intel.com) merged in patch http://review.whamcloud.com/14768/ |
| Comment by Andreas Dilger [ 26/May/15 ] |
|
Landed to master for 2.8.0. |