[LU-7939] ldiskfs_find_entry() returns ERR_PTR() but checked for NULL Created: 29/Mar/16  Updated: 23/Nov/16  Resolved: 05/Aug/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Major
Reporter: Dmitry Eremin (Inactive) Assignee: Dmitry Eremin (Inactive)
Resolution: Fixed Votes: 0
Labels: kw

Issue Links:
Duplicate
duplicates LU-8180 RHEL7 __ldiskfs_find_entry can now re... Resolved
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In lustre-release/ldiskfs/namei.c:

struct buffer_head *__ldiskfs_find_entry(struct inode *dir,
					const struct qstr *d_name,
					struct ldiskfs_dir_entry_2 **res_dir,
					int *inlined, struct htree_lock *lck)
{
[...]
bh = ldiskfs_getblk(NULL, dir, b++, 0, &err);
if (unlikely(err)) {
	if (ra_max == 0)
		return ERR_PTR(err);
[...]

old.bh = ldiskfs_find_entry(old.dir, &old.dentry->d_name,
				 &old.de, &old.inlined);
retval = -ENOENT;
if (!old.bh || le32_to_cpu(old.de->inode) != old.inode->i_ino)
	goto end_rename;


 Comments   
Comment by Gerrit Updater [ 29/Mar/16 ]

Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/19197
Subject: LU-7939 osd-ldiskfs: check IS_ERR() instead of NULL
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bf7e7d2aabdee428f7eeff36574e0f598ac75321

Comment by Dmitry Eremin (Inactive) [ 29/Mar/16 ]

We need to patch ldiskfs as well.

Comment by Gerrit Updater [ 27/Jul/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19197/
Subject: LU-7939 osd-ldiskfs: check IS_ERR() instead of NULL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 52a465cf16b438b6777675c35ed653063d936ad2

Comment by Peter Jones [ 05/Aug/16 ]

The original patch has landed. Anything further can be tracked under a new ticket

Generated at Sat Feb 10 02:13:13 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.