[LU-7950] Suspicious dereference of pointer before NULL check in lwp_device_fini()

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: Dmitry Eremin (Inactive)
• Assignee: Dmitry Eremin (Inactive)
• Resolution: Fixed
• Labels: kw, patch
• Severity: 3

Description

Suspicious dereference of pointer 'm->lpd_obd' before NULL check at line 377

• An event which alters the program's state, leading to the defect
  lwp_dev.c:375: 'm->lpd_obd' is dereferenced.
• An event which alters the program's state, leading to the defect
  lwp_dev.c:377: 'm->lpd_obd' is checked for NULL.

375			imp = m->lpd_obd->u.cli.cl_import;
376		 
377			LASSERT(m->lpd_obd);

Issue Links

• is related to: LU-8378 unused but set variables

Comments

[Dmitry Eremin (Inactive)]

the same in osp_device_fini():
Suspicious dereference of pointer 'osp->opd_obd' before NULL check at line 1341

[Gerrit Updater]

Arshad Hussain ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21024
Subject: LU-7950 osp: Move assignment below LASSERT()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: db6494631db78f0984f149361e6caf963c059619

[Peter Jones]

Dmitry

Could you please review this patch when you are back in the office?

Thanks

Peter

[Gerrit Updater]

Arshad Hussain ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21066
Subject: LU-7950 osp: Remove assigned but not used variable
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 58c45164de896ac6eae8c09fb38f8f40e399f125

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/21024/
Subject: LU-7950 osp: Remove assigned but not used variable
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 107c1d022ffd976b4a335f794de731cf9d57a514

[Peter Jones]

Landed for 2.9