[LU-7972] $REFORMAT in t-f is not used correctly Created: 01/Apr/16  Updated: 15/Jun/16  Resolved: 03/May/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Minor
Reporter: Emoly Liu Assignee: Emoly Liu
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

$REFORMAT is defined in test-framework.sh and used in the following code:

    if ! is_mounted $MOUNT && ! is_mounted $MOUNT2; then
        [ "$REFORMAT" ] && formatall
        # setupall mounts both MOUNT and MOUNT2 (if MOUNT_2 is set)

There is an issue that even if we set "REFORMAT=no", it will still format all.

I will submit a patch to fix it.

 Comments   
Comment by Gerrit Updater [ 01/Apr/16 ]

Emoly Liu (emoly.liu@intel.com) uploaded a new patch: http://review.whamcloud.com/19276
Subject: LU-7972 tests: use $REFORMAT in test-framework.sh correctly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0d9820e8c0f3d64d1b8d8228be1494046a50ae80

Comment by Gerrit Updater [ 02/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19276/
Subject: LU-7972 tests: use $REFORMAT in test-framework.sh correctly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 03eb7bb98d5d7f86b37cf4d3a8965ac71bd0693e

Comment by Emoly Liu [ 03/May/16 ]

Landed for 2.9.0

Comment by Andrew Perepechko [ 15/Jun/16 ]

REFORMAT was not documented to hold yes/no. It has worked for years with empty/nonempty params meaning to format or not to format. Random changes to the semantics of env vars simply for the purpose of "cleanup" do break existing scripts.

Generated at Sat Feb 10 02:13:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.