[LU-8003] ll_ddelete() has obsolete reference to find_cbdata() Created: 11/Apr/16 Updated: 04/Aug/17 Resolved: 08/Jul/16 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.9.0 |
| Fix Version/s: | Lustre 2.9.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | easy | ||
| Issue Links: |
|
||||||||||||
| Severity: | 3 | ||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||
| Description |
|
After http://review.whamcloud.com/19164 the following comment and ifdefed out code in ll_ddelete() is obsolete and should be removed. /* Disable this piece of code temproarily because this is called * inside dcache_lock so it's not appropriate to do lots of work * here. ATTENTION: Before this piece of code enabling, LU-2487 must be * resolved. */ #if 0 /* if not ldlm lock for this inode, set i_nlink to 0 so that * this inode can be recycled later b=20433 */ if (de->d_inode && !find_cbdata(de->d_inode)) clear_nlink(de->d_inode); #endif Also the comment before ll_unlink() should be removed or corrected. /* ll_unlink() doesn't update the inode with the new link count. * Instead, ll_ddelete() and ll_d_iput() will update it based upon if * there is any lock existing. They will recycle dentries and inodes * based upon locks too. b=20433 */ static int ll_unlink(struct inode *dir, struct dentry *dchild) |
| Comments |
| Comment by Gerrit Updater [ 29/Apr/16 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/19881 |
| Comment by Gerrit Updater [ 05/Jul/16 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19881/ |
| Comment by Joseph Gmitter (Inactive) [ 08/Jul/16 ] |
|
Landed to master for 2.9.0 |