[LU-8006] Specify ordering of TBF policy rules Created: 11/Apr/16  Updated: 29/May/21  Resolved: 29/Aug/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.7.0
Fix Version/s: Lustre 2.9.0

Type: Question/Request Priority: Major
Reporter: Mahmoud Hanafi Assignee: Li Xi (Inactive)
Resolution: Fixed Votes: 0
Labels: cea, patch

Issue Links:
Related
is related to LUDOC-328 documentation updates for complex TBF... Open
is related to LU-5620 nrs tbf policy based on opcode Resolved
is related to LU-7470 Extend TBF policy with NID/JobID expr... Resolved
is related to LU-14724 Kernel crash when setting NRS TBF policy Resolved
is related to LU-8008 Can't enable or add rules to TBF Resolved
is related to LU-3558 NRS TBF policy for QoS purposes Resolved
Rank (Obsolete): 9223372036854775807

 Description   

In the documentation it states " Whenever a queue is newly created, it goes though the rule list and takes the first matched rule as its rule, so that the queue knows its RPC token rate."

How does it the order the rules? Is it in the order they were created?

We want 2 initial sets of NID groups, 'Login' and 'compute'. But the compute nodes' NIDs are not uniquely different from the login nodes. But if we can order the rules we can list the login nodes first and then compute.



 Comments   
Comment by Andreas Dilger [ 11/Apr/16 ]

Currently the order of the TBF rules is the order in which they are created. I've recently discussed this with Li Xi that along with the change to allow complex TBF policies that specify combinations of NID, RPC opcode, JobID, UID/GID, etc, there needs to be a way to insert/delete rules in arbitrary order, as tools like iptables allow.

Comment by Gerrit Updater [ 12/Apr/16 ]

Li Xi (lixi@ddn.com) uploaded a new patch: http://review.whamcloud.com/19476
Subject: LU-8006 ptlrpc: interface for changing ranks of TBF rules
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 06ce138bbfc637f48d8e8be61d44798f9383cc6f

Comment by Gerrit Updater [ 13/Apr/16 ]

Li Xi (lixi@ddn.com) uploaded a new patch: http://review.whamcloud.com/19499
Subject: LU-8006 ptlrpc: cleanup codes of TBF command
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 59bede110333b39925d9c3f66702859cf2ff00ca

Comment by Mahmoud Hanafi [ 19/Apr/16 ]

we need these for 2.7.1 fe

Comment by Emoly Liu [ 22/Apr/16 ]

If needed, I can backport these patches to 2.7.1fe after they are landed.

Comment by Gerrit Updater [ 14/Jun/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19499/
Subject: LU-8006 ptlrpc: cleanup codes of TBF command
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d09237044382361b289c01a9f7412818b3599e79

Comment by Li Xi (Inactive) [ 27/Jul/16 ]

http://review.whamcloud.com/#/c/19476/ still needs review.

Comment by Gerrit Updater [ 29/Aug/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19476/
Subject: LU-8006 ptlrpc: specify ordering of TBF policy rules
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aa14b0b9a1521b3deb26a07eb8f7bb28ce793001

Comment by Peter Jones [ 29/Aug/16 ]

Landed for 2.9

Generated at Sat Feb 10 02:13:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.