[LU-8040] changelog_mask modifications from default do not persist across MDT restart

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Critical
• Reporter: Artem Blagodarenko (Inactive)
• Assignee: Niu Yawei (Inactive)
• Resolution: Fixed
• Labels: bgti, patch
• Severity: 3

Description

If the changelog_mask is updated from the default, e.g. by running on MGS:
lctl conf_param snx11155-MDT0000.changelog_mask=+CLOSE
The mask change is picked up by the MDS, but on MDS restart (e.g. on failover of MDT), the updated flag is not preserved. The changelog_mask reverts to its original setting.

lctl set_param -P command stores options to params file. This options
are aplied in server_start_targets during target mount. At least
changelog apply default options during initialization. So it reset
options applied by set_param -P.

Params log file processing should be moved after device initialization.
So new parameters aplied after default.

How to recreate:

lctl get_param mdd.*.changelog_mask
testfs.changelog_mask=
MARK CREAT MKDIR HLINK SLINK MKNOD UNLNK RMDIR RENME RNMTO OPEN  LYOUT TRUNC SATTR XATTR HSM MTIME CTIME 
lctl conf_param testfs-MDT0000.mdd.changelog_mask='MARK CREAT MKDIR HLINK SLINK MKNOD UNLNK RMDIR RENME RNMTO OPEN CLOSE LYOUT TRUNC SATTR XATTR HSM MTIME CTIME'
lctl get_param mdd.*.changelog_mask
testfs-MDT0000.changelog_mask=
MARK CREAT MKDIR HLINK SLINK MKNOD UNLNK RMDIR RENME RNMTO OPEN CLOSE LYOUT TRUNC SATTR XATTR HSM MTIME CTIME
#restart mdt
lctl get_param mdd.*.changelog_mask
MARK CREAT MKDIR HLINK SLINK MKNOD UNLNK RMDIR RENME RNMTO OPEN LYOUT TRUNC SATTR XATTR HSM MTIME CTIME

Comments

[Gerrit Updater]

Artem Blagodarenko ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19647
Subject: LU-8040 mgc: apply params after device initializaton
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c2608fe29f2dd340cea718c94adfb9f164cb9851

[Joseph Gmitter (Inactive)]

Hi Niu,
Could you please have a review of the patch?
Thanks.
Joe

[Gerrit Updater]

Artem Blagodarenko ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19854
Subject: LU-8040 mgc: Apply changelog defaults values in mdd_init0()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f061d1c6f2adacb6d2bcc96fb7511ba642e1f1ff

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19854/
Subject: LU-8040 mgc: Apply changelog defaults values in mdd_init0()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 36e5b7203d5f80b5ac1341a05a35c19915c05bd6

[Niu Yawei (Inactive)]

Patch landed.