[LU-8050] Drop llog_cookie usage from RPC on wire data Created: 21/Apr/16 Updated: 17/May/17 Resolved: 17/May/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.10.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | nasf (Inactive) | Assignee: | nasf (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Originally, obdo::o_lcookie is for destroy with unlink cookie from MDS, it is obsolete in 2.8. And then, it is reused by the OSP to save on memory allocations as following comment: /*
* this is a trick: to save on memory allocations we put cookie
* into the request, but don't set corresponded flag in o_valid
* so that OST doesn't interpret this cookie. once the request
* is committed on OST we take cookie from the request and cancel
*/
Currently, we needs more fields in the obdo structure to transfer more information from client to OST. The obdo::o_lcookie is good candidate. So we need adjust OSP logic to NOT use such field for non-onwire RPC data usage. |
| Comments |
| Comment by Gerrit Updater [ 26/Apr/16 ] |
|
Fan Yong (fan.yong@intel.com) uploaded a new patch: http://review.whamcloud.com/19784 |
| Comment by Gerrit Updater [ 13/Jan/17 ] |
|
Niu Yawei (yawei.niu@intel.com) uploaded a new patch: https://review.whamcloud.com/24876 |
| Comment by Gerrit Updater [ 13/Mar/17 ] |
|
Jinshan Xiong (jinshan.xiong@intel.com) merged in patch https://review.whamcloud.com/24876/ |
| Comment by Gerrit Updater [ 05/Apr/17 ] |
|
Bobi Jam (bobijam@hotmail.com) uploaded a new patch: https://review.whamcloud.com/26395 |
| Comment by nasf (Inactive) [ 17/May/17 ] |
|
The patch has been landed to master. |