[LU-8063] Fileset mount with automatic group lock Created: 25/Apr/16 Updated: 12/Jan/18 Resolved: 12/Jan/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Minor |
| Reporter: | Li Xi (Inactive) | Assignee: | Li Xi (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | patch | ||
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Recently patch of fileset mount support has been merged into master Group lock is a LDLM lock type which turns off LDLM locking on a file Thus, a mount option of "grouplock=$GID" could be added to indicate The mount option of group lock is not suitable to be used on the top Further more, currently, we don't have any way to avoid ldlm lock Anyway, I will push the patch that adds automatic group lock support |
| Comments |
| Comment by Gerrit Updater [ 25/Apr/16 ] |
|
Li Xi (lixi@ddn.com) uploaded a new patch: http://review.whamcloud.com/19760 |
| Comment by Peter Jones [ 25/Apr/16 ] |
|
Thanks Li Xi |
| Comment by Andreas Dilger [ 28/Apr/16 ] |
|
Before we land a patch like this, I think there needs to be a clear benefit to having it in the first place. Enabling group lock on every file in a subtree mount could potentially cause a lot of problems for applications running there, since it means that there will be no cache invalidation between clients, and writes from one client will not be seen by another client without an explicit sync() on the file. It isn't even clear if closing the file will cause the data to be flushed or not. Also, any files in this subtree may be permanently inaccessable to other clients that are not mounting with this same grouplock option, if one of the grouplock clients holds the file open, which will cause lock timeouts on the other clients and other potential problems. Since the main motivation for such a patch is performance due to reduced DLM locking, have you measured some performance improvement from using this patch? If yes, what kind of workload was run to see this performance improvement, and is there some other way to get this improvement with the current DLM without the need to have explicit mount options for such subtrees? That would benefit all Lustre clients, instead of the small subset that would be mounted with the grouplock option. |
| Comment by Li Xi (Inactive) [ 29/Apr/16 ] |
|
I totally agree that we shouldn't merge this patch in a rush without fully We currently don't have any application which is using grouplock. I myself, is However, I do believe that there is some workloads which can be accelerated by Of course, those use cases are not traditional fields that Lustre is focusing Obviously, grouplock won't be useful for all of those cases. Its use cases |
| Comment by Andreas Dilger [ 02/Nov/17 ] |
|
Li Xi, is this work replaced by the LCOC/PCC feature? Otherwise, I think that using group lock is not really the right way to fix this problem. Group lock still needs to get a DLM lock from the server, so it only makes a difference when there are multiple clients accessing the same file, to avoid lock contention. |
| Comment by Li Xi (Inactive) [ 12/Jan/18 ] |
|
Hi Andreas, Yeah, I think PCC might be better solution for some of the use cases mentioned in this ticket. And Rreadonly-PCC uses grouplock. So I am closing this ticket. It was good to discuss though. |