[LU-8095] switch LNET_* static function names to lower case Created: 04/May/16 Updated: 15/Oct/20 Resolved: 15/Oct/20 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.8.0 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Sebastien Buisson (Inactive) | Assignee: | Amir Shehata (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | patch | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Replace the upper-case names with lower-case names for the following static inline functions from LNet: |
| Comments |
| Comment by Gerrit Updater [ 04/May/16 ] |
|
Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: http://review.whamcloud.com/19964 |
| Comment by Joseph Gmitter (Inactive) [ 05/May/16 ] |
|
Hi Doug, |
| Comment by James A Simmons [ 05/May/16 ] |
|
This change makes me nervous. These functions are exposed to external software stacks (Cray's DVS for example) so this change would break them very badly. |
| Comment by Doug Oucharek (Inactive) [ 05/May/16 ] |
|
Is this being done in response to a kernel coding guideline? |
| Comment by James A Simmons [ 05/May/16 ] |
|
I know they frown on camel case which we also have exported in our LNet layer. It is the same problem in that if we remove the camel case naming of the LNet functions then we break external modules. As for all capital name functions I don't know if they are so strict. I never seen checkpatch complain about this. |
| Comment by Sebastien Buisson (Inactive) [ 09/May/16 ] |
|
Hi, I am proposing this patch following Andreas' comment: |