[#LU-812] Support for Linux 3.0 kernels

[LU-812] Support for Linux 3.0 kernels Created: 01/Nov/11 Updated: 21/Jul/21 Resolved: 04/Dec/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Lustre 2.4.0

Type:

Improvement

Priority:

Minor

Reporter:

Cory Spitz

Assignee:

Yang Sheng

Resolution:

Fixed

Votes:

Labels:

None

Attachments:

3.0-client-patches.tar.gz

mutex.diff

no-autoconf-included.patch

Issue Links:

Duplicate
is duplicated by	~~LU-3518~~	liblustreapi.a not forward compatible...	Resolved
Related
is related to	~~LU-1718~~	fix Lustre NFS re-export for 3.0+ ker...	Resolved
is related to	~~LU-14877~~	Lock inversion between inode mutex an...	Resolved
is related to	~~LU-2196~~	Build shared version of liblustreapi	Resolved
is related to	~~LU-2148~~	Kernel update for latest FC18 kernel	Resolved

Sub-Tasks:

Key

Summary

Type

Status

Assignee

LU-1718

fix Lustre NFS re-export for 3.0+ ker...

Technical task

Resolved

WC Triage

Rank (Obsolete):

4458

Description

Cray is interested in bringing Linux 3.0 support to clients and servers. We'll focus on clients first since that will obviously be easiest. However, Lustre won't even configure in a Linux 3.0 environment. Initially, we plan on submitting patches to the build process going. Eventually, we'll work our way up to the server patch series. Of course, the BKL was removed and we'll be looking for suggestions on how to work around that and other major changes. I presume that RHEL will go to Linux 3.x eventually, but Cray will initially be focusing on SLES SP2. Hopefully we can find a way to make the patch sets similar.

We'd like to at least have 3.0 clients be considered upstream for Lustre 2.3.

Comments

Comment by Wally Wang (Inactive) [ 15/Nov/11 ]

Temporary Lustre client patches for SLES11 SP2/Linux 3.0

Comment by Wally Wang (Inactive) [ 15/Nov/11 ]

The issues here are for client code only. Attached is a set of patches
that mostly just trying to temporarily workaround or ifdef'd to get it
compiled. Hower, they identify at least the following issues:

1. No longer has smp_lock.h.
2. No linux/config.h
3. - rw26.patch
No longer has .sync_page in struct address_space_operations.
4. - libcfsmakefile.patch
Need linux/libcfs-linux-obj in libcfs/libcfs/Makefile.in

5. - shrinker.patch
struct shrinker change along with argument change shrink()

6. - spinlock.patch
SPIN_LOCK_UNLOCKED, RW_LOCK_UNLOCKED deprecated

7. - linuxlock.patch
a: No longer have init_MUTEX, init_MUTEX_LOCKED
b: DECLARE_MUTEX becomes DEFINE_SEMAPHORE
c: No BKL lock_kernel()/unlock_kernel()
d: dcache_lock is gone, replaced by fine grained locks. ~~LU-156~~

8. - fslock.patch
lock in fs_struct changed from rwlock_t to spinlock_t

9. - ioctl.patch
No longer has ioctl in file_operations.

10. - sock.patch
a. wait_queue_head_t *sk_sleep; becomes sk_sleep(sock->sk)
b. tcp_sendpage() takes struct sock instead of socket in the 1st param

11. - ctlname.patch
No longer has .ctl_name in ctl_table

12. - fsync.patch
Arguments in fsync function in struct file_operations changed.

13. - atomic_mntcount.patch
mnt_count in struct vfsmount changed to percpu count with a new mnt_longterm

14. - atomic_dcount.patch
a. Type of d_count in struct dentry no longer be atomic_t,
b. No longer has dget_locked()

15. - quota.patch
a. There is no sb_any_quota_active(sb) or sb_any_quota_enabled(sb)
b. QUOTA_OK, NO_QUOTA not defined
c. quota_on has 4 args but different from the older vresion

16. - statfs-lu766-ps4.patch
Argument change, ~~LU-766~~ has the fix, applied patchset 4

17. - loop.patch
a. No longer has unplug_fn() in struct request_queue

18. - ddlete.patch
Add 'const' qualifier to the argument of .d_delete in dentry_operations

19. - dcompare-lu154.patch
Argments change in .d_compare of struct dentry_operations - ~~LU-154~~

20. - permission.patch
a. Arguments change in .permission of strcut inode_operations
b. Arguments change in generic_permission()

21. - clearinode.patch
super_operations: there is no clear_inode, delete_inode.
they are replaced by eevict_inode

22. - inodesetattr.patch
No longer has inode_setattr

23. - bitops.patch
No longer have ext2_test/set/clear_bit defined

24. - getsb.patch
get_sb in struct file_system_type changed to mount, along with arguments

25. - synchronize.patch
synchronize_rcu() is not defined

Comment by Wally Wang (Inactive) [ 10/Jan/12 ]

submitted the following changes for review:

http://review.whamcloud.com/#change,1942 SPIN_LOCK_UNLOCKED no longer exists
http://review.whamcloud.com/#change,1949 replace DECLARE_MUTEX, init_MUTEX/_LOCKED with semaphore
http://review.whamcloud.com/#change,1950 file_operations.fsync needs 4 arguments
http://review.whamcloud.com/#change,1951 replace get_sb with mount in struct file_system_type
http://review.whamcloud.com/#change,1952 synchronize_rcu no longer a define

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,client,el5,ofa #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » i686,client,el6,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,server,el5,ofa #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » i686,server,el5,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » i686,server,el6,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_compat25.h

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » i686,server,el5,ofa #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » i686,client,el5,inkernel #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 19/Jan/12 ]

Integrated in lustre-master » i686,client,el5,ofa #436
~~LU-812~~ synchronize_rcu no longer a define (Revision 440d5b2c1e96c02fed5b839f5cd354032482cd3f)

Result = SUCCESS
Oleg Drokin : 440d5b2c1e96c02fed5b839f5cd354032482cd3f
Files :

lustre/include/linux/lustre_compat25.h
lustre/autoconf/lustre-core.m4

Comment by Lai Siyao [ 19/Jan/12 ]

Hi Wally, I attached a patch about mutex here, could you help check and land it?

Comment by Wally Wang (Inactive) [ 24/Jan/12 ]

Hi Siyao, I applied your patch which needed some merges. Please review. Thanks,

Wally

Comment by Wally Wang (Inactive) [ 24/Jan/12 ]

Please review:

http://review.whamcloud.com/#change,1985 - sync_page() removed from struct address_space_operations

Comment by Wally Wang (Inactive) [ 24/Jan/12 ]

AUTOCONF_INCLUDED has been removed since 2.6.37. Not sure we still need it. I think it was initially added in Oracle bz 11802 att. 11752.
I attached a patch, no-autoconf-included.patch, of the following change for 30+ files:

+#include <linux/version.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 37)
#ifndef AUTOCONF_INCLUDED
#include <linux/config.h>
#endif
+#endif

Is the patch ok? Or if linux/config.h still needed? Please comment, thanks.

Wally

Comment by Wally Wang (Inactive) [ 24/Jan/12 ]

Please review:

http://review.whamcloud.com/#change,2000 - remove BKL reference

Comment by Andreas Dilger [ 09/Feb/12 ]

Wally, I don't think every file needs to include <linux/config.h> anymore. It is worthwhile to submit a patch that removes it, and see if it will build on all the kernels.

Comment by Wally Wang (Inactive) [ 16/Feb/12 ]

The patch is:

http://review.whamcloud.com/#change,2146 - AUTOCONF_INCLUDED removed

Comment by Wally Wang (Inactive) [ 09/Mar/12 ]

Linux 3.3 address_space_operations.migratepage has 4 args, the patch is in:

http://review.whamcloud.com/#change,2279 - migratepage has 4 args