[LU-8185] Non-ANSI function declarations

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.13.0
• Type: Bug
• Priority: Trivial
• Reporter: Oleg Drokin
• Assignee: WC Triage
• Resolution: Fixed
• Labels: easy
• Severity: 3

Description

There's a bunch of non-ANSI function declarations in Lustre that need to be converted to proper format:

libcfs/libcfs/linux/linux-tracefile.c:54:29: error: non-ANSI function declaration of function 'cfs_tracefile_init_arch'
libcfs/libcfs/linux/linux-tracefile.c:97:30: error: non-ANSI function declaration of function 'cfs_tracefile_fini_arch'
libcfs/libcfs/linux/linux-tracefile.c:115:30: error: non-ANSI function declaration of function 'cfs_tracefile_read_lock'
libcfs/libcfs/linux/linux-tracefile.c:120:32: error: non-ANSI function declaration of function 'cfs_tracefile_read_unlock'
libcfs/libcfs/linux/linux-tracefile.c:125:31: error: non-ANSI function declaration of function 'cfs_tracefile_write_lock'
libcfs/libcfs/linux/linux-tracefile.c:130:33: error: non-ANSI function declaration of function 'cfs_tracefile_write_unlock'
libcfs/libcfs/linux/linux-tracefile.c:135:47: error: non-ANSI function declaration of function 'cfs_trace_buf_idx_get'
lnet/lnet/api-ni.c:1639:12: error: non-ANSI function declaration of function 'LNetNIFini'
lnet/selftest/console.c:1819:20: error: non-ANSI function declaration of function 'lstcon_session_end'
libcfs/libcfs/linux/linux-tracefile.c:54:29: warning: non-ANSI function declaration of function 'cfs_tracefile_init_arch'
libcfs/libcfs/linux/linux-tracefile.c:97:30: warning: non-ANSI function declaration of function 'cfs_tracefile_fini_arch'
libcfs/libcfs/linux/linux-tracefile.c:115:30: warning: non-ANSI function declaration of function 'cfs_tracefile_read_lock'
libcfs/libcfs/linux/linux-tracefile.c:120:32: warning: non-ANSI function declaration of function 'cfs_tracefile_read_unlock'
libcfs/libcfs/linux/linux-tracefile.c:125:31: warning: non-ANSI function declaration of function 'cfs_tracefile_write_lock'
libcfs/libcfs/linux/linux-tracefile.c:130:33: warning: non-ANSI function declaration of function 'cfs_tracefile_write_unlock'
libcfs/libcfs/linux/linux-tracefile.c:135:47: warning: non-ANSI function declaration of function 'cfs_trace_buf_idx_get'
lnet/lnet/api-ni.c:1639:12: warning: non-ANSI function declaration of function 'LNetNIFini'
lnet/selftest/console.c:1819:20: warning: non-ANSI function declaration of function 'lstcon_session_end'
lustre/obdclass/cl_object.c:1229:34: error: non-ANSI function declaration of function 'cl_env_percpu_get'
lustre/obdclass/cl_object.c:1229:34: warning: non-ANSI function declaration of function 'cl_env_percpu_get'
lustre/ptlrpc/pack_generic.c:121:29: error: non-ANSI function declaration of function 'lustre_msg_early_size'
lustre/ptlrpc/pack_generic.c:121:29: warning: non-ANSI function declaration of function 'lustre_msg_early_size'
lustre/ptlrpc/pinger.c:58:34: error: non-ANSI function declaration of function 'ptlrpc_pinger_suppress_pings'
lustre/ptlrpc/pinger.c:565:28: error: non-ANSI function declaration of function 'ptlrpc_pinger_wake_up'
lustre/ptlrpc/pinger.c:58:34: warning: non-ANSI function declaration of function 'ptlrpc_pinger_suppress_pings'
lustre/ptlrpc/pinger.c:565:28: warning: non-ANSI function declaration of function 'ptlrpc_pinger_wake_up'

Issue Links

• is related to: LU-6142 Enforce Linux kernel coding style in ...

Comments

[Andreas Dilger]

This was fixed with patch https://review.whamcloud.com/35773 "LU-6142 libcfs: Fix style issues for linux-tracefile.c".