[LU-8192] Unsafe access to keyrings in gss_kt_instantiate

• Status: Open
• Project: Lustre
• Type: Bug
• Priority: Major
• Reporter: Oleg Drokin
• Assignee: Jeremy Filizetti
• Resolution: Unresolved
• Labels: patch, x
• Severity: 3

Description

Apparently you cannot just fetch a keyring like:

rc = key_link(key_tgcred(current)->session_keyring, key);

This is unsafe and supposedly not even accessible, because sparse warns it's in wrong address space, also in
request_key_unlink():

                ring = key_get(rcu_dereference(key_tgcred(tsk)
                                               ->session_keyring));

The errors I get are:

lustre/ptlrpc/gss/gss_keyring.c:1308 warning: incorrect type in argument 1 (different address spaces) expected "struct key *keyring" got "struct key [noderef] <asn:4>*const [noderef] <asn:4>session_keyring"
lustre/ptlrpc/gss/gss_keyring.c:695 warning: cast removes address space of expression

Comments

[Joseph Gmitter (Inactive)]

Hi Jeremy,

Can you look at this code? Looks like it was recently added by IU.

Thanks.
Joe

[Gerrit Updater]

Kit Westneat ([e-mail]) uploaded a new patch: https://review.whamcloud.com/26205
Subject: LU-8192 nodemap: modify lctl to allow non-contiguous nm ranges
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 77e53e7967aa77e2d60f31135b4bdc1d686c1a47