[LU-8304] libcfs_debug_dumplog calls potentially sleeping function in wrong state Created: 20/Jun/16  Updated: 07/Apr/20  Resolved: 07/Apr/20

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.14.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Oleg Drokin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-9859 libcfs simplification Open
is related to LU-13253 sanity/177 leaves threads blocked in ... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

libcfs_debug_dumplog() sets task state to INTERRUPTIBLE and then calls kthread_run() that might sleep.

It's mostly harmless here, but still should be avoided as the kernel prints a nastygram about it when it happens.

I guess just moving the state setting to after kthread_run call is all that's needed.

 Comments   
Comment by Gerrit Updater [ 20/Jun/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/20876
Subject: LU-8304 libcfs: Do not call kthread_run in wrong state
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2939b69711fb3a2a1eeed996795c2a179a5b25c8

Comment by Gerrit Updater [ 02/Feb/20 ]

James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37398
Subject: LU-8304 libcfs: convert debug_ctlwq to a completion.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7da0642bf721b43fe1bc9d67e12fdea8f537fdfc

Comment by Gerrit Updater [ 08/Feb/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37398/
Subject: LU-8304 libcfs: convert debug_ctlwq to a completion.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: acb6ee1f1fbeebad43a3d415bfcf47edd05c2aba

Generated at Sat Feb 10 02:16:22 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.