[LU-8330] Incorrect ioctl definitions declaring a pointer to buffer instead of buffer argument.

• Status: In Progress
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: Nathaniel Clark
• Resolution: Unresolved
• Labels: patch
• Severity: 3

Description

There are no visible effects from this bug just yet, but the mechanism for declaring ioctls is used improperly with the below ones.

The structure ioctl is supposedly operates on is passed in as a pointer therefore breaking versioning.

We cannot just change the definition or it would break the old tools, but we can declare an old and new ones alongside and handle them both the same I guess.

#define LL_IOC_HSM_COPY_START           _IOW('f', 214, struct hsm_copy *)
#define LL_IOC_HSM_COPY_END             _IOW('f', 215, struct hsm_copy *)
#define IOC_OBD_STATFS                  _IOWR('f', 164, struct obd_statfs *)
#define IOC_MDC_LOOKUP          _IOWR(IOC_MDC_TYPE, 20, struct obd_device *)
#define IOC_MDC_GETFILESTRIPE   _IOWR(IOC_MDC_TYPE, 21, struct lov_user_md *)
#define IOC_MDC_GETFILEINFO     _IOWR(IOC_MDC_TYPE, 22, struct lov_user_mds_data *)
#define LL_IOC_MDC_GETINFO      _IOWR(IOC_MDC_TYPE, 23, struct lov_user_mds_data *)

Issue Links

• is related to: LU-8400 Remove OBD_IOC_GET_MNTOPT ioctl as it...
• is related to: LU-8329 All structures referenced from IOCTLs...

Comments

[Gerrit Updater]

Nathaniel Clark ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21296
Subject: LU-8330 wiretest: Add IOCTL checking to wiretest
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c25a8fe4591bbe2cf22b8045bfd51fdcf6de2b4e

[Andreas Dilger]

See also https://bugzilla.lustre.org/show_bug.cgi?id=20731 for a discussion of fixing the ioctl definitions.