[LU-8360] obd_set_info_async error suppressed Created: 01/Jul/16  Updated: 19/Mar/19  Resolved: 13/Jul/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Minor
Reporter: Yang Sheng Assignee: Yang Sheng
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

This bug is reported by Seagate:
lustre-wc-rel/lustre/llite/llite_lib.c:

static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
                                    struct vfsmount *mnt)
{
...
        checksum = sbi->ll_flags & LL_SBI_CHECKSUM;
        err = obd_set_info_async(NULL, sbi->ll_dt_exp, sizeof(KEY_CHECKSUM),
                                 KEY_CHECKSUM, sizeof(checksum), &checksum,
                                 NULL);
        cl_sb_init(sb);

        err = obd_set_info_async(NULL, sbi->ll_dt_exp, sizeof(KEY_CACHE_SET),<--- Variable 'err' is reassigned a value before the old one has been used.
                                 KEY_CACHE_SET, sizeof(*sbi->ll_cache),
                                 sbi->ll_cache, NULL);

        sb->s_root = d_make_root(root);
        if (sb->s_root == NULL) {
                CERROR("%s: can't make root dentry\n",
                        ll_get_fsname(sb, NULL, 0));
                GOTO(out_root, err = -ENOMEM);
        }
...

This ticket want to trace patch landed to master.



 Comments   
Comment by Gerrit Updater [ 01/Jul/16 ]

Yang Sheng (yang.sheng@intel.com) uploaded a new patch: http://review.whamcloud.com/21125
Subject: LU-8360 llite: check return value for obd_set_info_async
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bb72557ab87d56c9a5fce04db34b10771aa46ad8

Comment by Gerrit Updater [ 11/Jul/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21125/
Subject: LU-8360 llite: check return value for obd_set_info_async
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a04d586405b7fa8aaa2f033f5b6b865c475e7ec8

Comment by Peter Jones [ 13/Jul/16 ]

Landed for 2.9

Generated at Sat Feb 10 02:16:52 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.