[LU-837] missed semaphore release in gss_do_ctx_init_rpc Created: 12/Nov/11  Updated: 12/Dec/11  Resolved: 12/Dec/11

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.1.0, Lustre 2.2.0
Fix Version/s: Lustre 2.2.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Hongchao Zhang
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 4818

 Description   

Shadow reports that in gss_do_ctx_init_rpc we have this nice code:

cfs_down_read(&obd->u.cli.cl_sem);
if (obd->u.cli.cl_import == NULL)

{ CERROR("obd %s: import has gone\n", obd->obd_name); RETURN(-EINVAL); <<< - missing up read before here. }

imp = class_import_get(obd->u.cli.cl_import);
cfs_up_read(&obd->u.cli.cl_sem);

 Comments   
Comment by Peter Jones [ 16/Nov/11 ]

Hongchao

Could you please look into this one

Thanks

Peter

Comment by Hongchao Zhang [ 16/Nov/11 ]

the patch is tracked at http://review.whamcloud.com/#change,1705

Comment by Peter Jones [ 12/Dec/11 ]

Landed for 2.2

Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,client,el5,ofa #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,server,el5,ofa #376
LU-837 release semaphore for error case in gss_do_ctx_init_rpc (Revision 8003be0425c37fca66e463781a02e37be5fb2c7e)

Result = SUCCESS
Oleg Drokin : 8003be0425c37fca66e463781a02e37be5fb2c7e
Files :

  • lustre/ptlrpc/gss/gss_cli_upcall.c
Generated at Sat Feb 10 01:10:52 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.