[LU-8371] Optimize open of known negative dentry Created: 06/Jul/16  Updated: 22/Aug/16  Resolved: 22/Aug/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Oleg Drokin
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

While working with Al Viro on some corner cases in atomic open, I noticed that we are doing a lot more work than necessary there.

If we were called with a negative dentry - that means just now we revalidated that dentry so there's no point in contacting MDS to open that file (unless it's a create request), we can just return ENOENT and be done with it which speeds up 99.9% of all usecases and the remaining 0.15 where it's a valid race, we just resolve it the other way as is perfectly fine for us to do.



 Comments   
Comment by Gerrit Updater [ 06/Jul/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/21161
Subject: LU-8371: llite: optimize atomic_open of negative dentry.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 34867f1a3a4f8f2cbb622b0b5b4ccbd88f679249

Comment by Gerrit Updater [ 06/Jul/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/21168
Subject: LU-8371 llite: Trust creates in revalidate too.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2852d1a30a7778c233b22ad477e85ff75e5097d0

Comment by Gerrit Updater [ 11/Aug/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21161/
Subject: LU-8371 llite: optimize atomic_open of negative dentry.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7334a2d33cc4cf4cda0c81b126c4cb8ab28a888d

Comment by Gerrit Updater [ 22/Aug/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21168/
Subject: LU-8371 llite: Trust creates in revalidate too.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9573911bfb4a2c3d7e2047c9d5f5440d9c7e7db5

Comment by Peter Jones [ 22/Aug/16 ]

Landed for 2.9

Generated at Sat Feb 10 02:16:58 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.