[LU-8372] Suspicious dereference of pointer 'vma->vm_file' in ll_vm_{open|close}

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: Dmitry Eremin (Inactive)
• Assignee: Dmitry Eremin (Inactive)
• Resolution: Fixed
• Labels: kw
• Severity: 3

Description

static void ll_vm_open(struct vm_area_struct * vma)
{
            struct inode *inode    = file_inode(vma->vm_file); <== 'vma->vm_file' is dereferenced by being passed as argument 1 to function 'file_inode'.
            struct vvp_object *vob = cl_inode2vvp(inode);

            ENTRY;
            LASSERT(vma->vm_file); <== 'vma->vm_file' is checked for NULL.
            LASSERT(atomic_read(&vob->vob_mmap_cnt) >= 0);
            atomic_inc(&vob->vob_mmap_cnt);
            EXIT;
}

So, LASSERT(vma->vm_file) is useless because if it's NULL it will crash in file_inode(vma->vm_file).

Comments

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21171
Subject: LU-8372 llite: Fix suspicious dereference of pointer 'vma->vm_file'
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: df7244f5f9cdaa9be7cfe13ff2d01a5e31c58613

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/21171/
Subject: LU-8372 llite: Fix suspicious dereference of pointer 'vma->vm_file'
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9d8469694738288fcd246a1e9f22c47918a32c58

[Joseph Gmitter (Inactive)]

Landed to master for 2.9.0