[LU-8390] e2fsprogs builds incorrectly on some sles12 versions

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Major
• Reporter: Bob Glossman (Inactive)
• Assignee: Bob Glossman (Inactive)
• Resolution: Fixed
• Severity: 3

Description

The distro name reported by the lsb_release command has changed in some versions of sles12. This change causes the e2fsprogs build process for the master-lustre branch to choose the wrong .spec file to build with. Using the wrong .spec file results in generating the wrong packages, generic style RPMs instead of SLES compatible RPMs.

The following small repair to the build script can fix the problem:

--- a/contrib/build-rpm
+++ b/contrib/build-rpm
@@ -75,7 +75,7 @@ case "$DISTRO-$RELEASE" in
     Fedora-1[5-9]) DISTRO=RHEL; RELEASE=7;;
     Fedora-2[0-9]) DISTRO=RHEL; RELEASE=7;;
     SUSE\ LINUX-11*) DISTRO=SUSE_LINUX; RELEASE=11;;
-    SUSE\ LINUX-12*) DISTRO=SUSE_LINUX; RELEASE=12;;
+    SUSE\ LINUX-12* | SUSE-12*) DISTRO=SUSE_LINUX; RELEASE=12;;
 esac
 
 SPECFILE="$currdir/e2fsprogs-${DISTRO// /_}-$RELEASE.spec"

Comments

[Gerrit Updater]

Bob Glossman ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21237
Subject: LU-8390 build: use correct .spec file for sles12
Project: tools/e2fsprogs
Branch: master-lustre
Current Patch Set: 1
Commit: 40a37385f5dc01da1dc2fc0562661c50fd5a61ea

[Bob Glossman (Inactive)]

Andreas,
I strongly suspect but can't prove that test problems with e2fsprogs are really DCO issues. It just failed a test run on el7, which has worked fine before. So problems not limited to sles11sp3 only.

[Gerrit Updater]

Andreas Dilger ([e-mail]) merged in patch http://review.whamcloud.com/21237/
Subject: LU-8390 build: use correct .spec file for SLES 12
Project: tools/e2fsprogs
Branch: master-lustre
Current Patch Set:
Commit: cbbd8d6d6d5017355afc9cba4a25fe2aeb0dd494