[LU-8400] Remove OBD_IOC_GET_MNTOPT ioctl as it's only used to pass info between mdd and mdt Created: 14/Jul/16 Updated: 02/Oct/17 Resolved: 02/Oct/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Nathaniel Clark | Assignee: | Henri Doreau (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | easy | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
The OBD_IOC_GET_MNTOPT ioctl should be removed because it's not actually usable in user-space and is only used by kernel in mdd and mdt to pass information. |
| Comments |
| Comment by Andreas Dilger [ 15/Jul/16 ] |
|
It appears that both OBD_IOC_GET_MNTOPT and mdd_maxeasize_get() should either be replaced by a single mdd_dtconf_get() method that returns struct dt_device_param to the caller, or GET_MNTOPT should be replaced by a new mdd_mntopt_get() method for consistency. In either case the OBD_IOC_GET_MNTOPT definition should be removed, though a stub should be left behind, like: /* was OBD_IOC_GET_MNTOPT _IOW ('f', 220, mntopt_t) until 2.9 */
|
| Comment by Henri Doreau (Inactive) [ 29/Aug/17 ] |
|
BTW I realized that another ioctl had opcode 220... good time to remove it. |
| Comment by Gerrit Updater [ 29/Aug/17 ] |
|
Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: https://review.whamcloud.com/28777 |
| Comment by Gerrit Updater [ 02/Oct/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28777/ |
| Comment by Peter Jones [ 02/Oct/17 ] |
|
Landed for 2.11 |