[LU-8402] OBD_CONNECT_* flags retirement Created: 14/Jul/16  Updated: 25/Mar/19  Resolved: 26/Mar/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0, Lustre 2.10.7

Type: Improvement Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: easy, medium

Issue Links:
Related
is related to LU-1904 deprecate unused OBD_CONNECT flags Resolved
Rank (Obsolete): 9223372036854775807

 Description   

Several of the OBD_CONNECT_* flags have outlived their usefulness and should just always assume to be set or unset so that affected code paths can be simplified.

[10:23:19 AM] John Hammond: It seems like some of the OBD_CONNECT_* flags can be assumed to be set for all supported versions and then some. For example OBD_CONNECT_IBITS. Should we put together a list of such flags which can be required at connect time and then other code that check these flags can be simplified?
[10:31:36 AM] Andreas Dilger: I wouldn't be against that
[10:31:55 AM] John Hammond: OK, I'll open a ticket.
[10:35:55 AM] Andreas Dilger: there are two ways that could be handled... either require that it be set and refuse clients that don't have it, or assume that the flag is set at the server and then eventually stop sending it from the client and deprecate it completely
[10:38:25 AM] John Hammond: I was leaning towards the first. What do you suggest?
[11:26:15 AM] Andreas Dilger: I'd be inclined toward the second. I don't see much value to keeping around flags forever that will always be set.

Candidates for retirement include:

OBD_CONNECT_IBITS
OBD_CONNECT_ATTRFID
OBD_CONNECT_NODEVOH
OBD_CONNECT_CANCELSET
OBD_CONNECT_REAL
OBD_CONNECT_FID
OBD_CONNECT_VBR
OBD_CONNECT_LOV_V3
OBD_CONNECT_FULL20

There are probably others as well. Some archeology is needed to determine in which versions these flags were added or started to be ignored.

 Comments   
Comment by Gerrit Updater [ 09/Nov/17 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/30009
Subject: LU-8402 ldlm: assume OBD_CONNECT_IBITS
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 523aee1dbaebd3b2189f93a8e4963272a6a8140a

Comment by Gerrit Updater [ 09/Nov/17 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/30010
Subject: LU-8402 llite: assume OBD_CONNECT_ATTRFID
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5186087b35c0e973c7381a98800765236362565b

Comment by Gerrit Updater [ 10/Nov/17 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/30036
Subject: LU-8402 llite: simplify ll_inode_revalidate()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 35445f03afce03fd06ce269542f3a448fb20fc41

Comment by Gerrit Updater [ 01/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30009/
Subject: LU-8402 ldlm: assume OBD_CONNECT_IBITS
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c7a833830de691967081cd7a42199b924ea7efdc

Comment by Gerrit Updater [ 01/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30010/
Subject: LU-8402 llite: assume OBD_CONNECT_ATTRFID
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: deaef32d1fd60530f60c5d3e38d11ead8234ac05

Comment by Gerrit Updater [ 01/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30036/
Subject: LU-8402 llite: simplify ll_inode_revalidate()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a430c3376c6b08d2264d4e0787e5403445f1bb7a

Comment by Peter Jones [ 01/Dec/17 ]

Any more patches to come under this ticket or can it be marked as RESOLVED?

Comment by John Hammond [ 05/Dec/17 ]

Let's resolve this and a new issue can be opened when we retire more flags.

Comment by Joseph Gmitter (Inactive) [ 26/Mar/18 ]

opening to add fix version and resolving again.

Comment by Gerrit Updater [ 15/Jan/19 ]

Hongchao Zhang (hongchao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34027
Subject: LU-8402 ldlm: assume OBD_CONNECT_IBITS
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 0acb1ab935fadf7712e50afc53dd67dc8778cdb1

Comment by Gerrit Updater [ 01/Feb/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34027/
Subject: LU-8402 ldlm: assume OBD_CONNECT_IBITS
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 2bc39a18041e40821195ef445269b282a9ec8fdb

Generated at Sat Feb 10 02:17:14 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.