[LU-8403] OBD_NOTIFY_* flags cleanup Created: 14/Jul/16  Updated: 26/Mar/17  Resolved: 26/Mar/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.10.0

Type: Improvement Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: easy

Rank (Obsolete): 9223372036854775807

 Description   

Half of the OBD_NOTIFY_* flags are essentially useless but we still have code that used them. The useless ones are

OBD_NOTIFY_CREATE
OBD_NOTIFY_CONNECT
OBD_NOTIFY_SYNC_NONBLOCK
OBD_NOTIFY_SYNC
OBD_NOTIFY_CONFIG
  1. Server side OBDs do not implement o_notify and so the OBD_NOTIFY_CONFIG notification in server_start_targets() is useless and can be removed.
  2. The data parameter of obd_notify() and obd_notify_observer() may be removed.
  3. lov_notify() may be simplified by assuming that watched is not NULL.
  4. The OBD_NOTIFY_CONNECT notification in lov_connect() is useless and can be removed.
  5. The OBD_NOTIFY_ACTIVE notification in lmv_connect_mdc() is useless and can be rremoved.
  6. lco_flags is never checked in llite and can be removed.
  7. enum config_flags can be removed.

 Comments   
Comment by Gerrit Updater [ 19/Jul/16 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/21420
Subject: LU-8403 obd: remove OBD_NOTIFY_CREATE
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 806c2deb78a4985ca607cdb4c9e89bd1a93ca6f8

Comment by John Hammond [ 19/Jul/16 ]

And http://review.whamcloud.com/#/c/21421/.
And http://review.whamcloud.com/#/c/21422/.

Comment by Gerrit Updater [ 17/Dec/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/21420/
Subject: LU-8403 obd: remove OBD_NOTIFY_CREATE
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39bd8d0aa62d8f113e9fe732f686bdccdfeedf5f

Comment by Gerrit Updater [ 19/Dec/16 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/24428
Subject: LU-8403 obd: remove unused data parameter from obd_notify()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9010e6a48411c3cf71fd11ca2afd8dbd9d02a739

Comment by Gerrit Updater [ 01/Mar/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/21421/
Subject: LU-8403 obd: remove OBD_NOTIFY_SYNC

{,_NONBLOCK}

Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2789a4b0852a97a10eda6b3ffd6166f6d99d329f

Comment by Gerrit Updater [ 09/Mar/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/21422/
Subject: LU-8403 obd: remove OBD_NOTIFY_CONFIG
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2a433d0d62dc51f2d79e6179662b950188ad6a2b

Comment by Gerrit Updater [ 26/Mar/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/24428/
Subject: LU-8403 obd: remove unused data parameter from obd_notify()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f519ec213874cedc3a07f8a47d87eac3a6279a82

Comment by Peter Jones [ 26/Mar/17 ]

Landed for 2.10

Generated at Sat Feb 10 02:17:14 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.