[LU-8451] assert if cpu_pattern specifies exactly one cpu in the partition Created: 30/Jul/16  Updated: 30/Jan/22  Resolved: 30/Jan/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Amir Shehata (Inactive) Assignee: Amir Shehata (Inactive)
Resolution: Duplicate Votes: 0
Labels: None

Issue Links:
Related
is related to LU-8492 ptlrpc: Correctly calculate hrp->hrp_... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

cpu_pattern can sepcify exactly 1 cpu in a partition:
"0[0]". That means CPT0 will have CPU 0. CPU 0 can have
hyperthreading enabled. This combination would result in
weight = cfs_cpu_ht_nsiblings(0);
hrp->hrp_nthrs = cfs_cpt_weight(ptlrpc_hr.hr_cpt_table, i);
hrp->hrp_nthrs /= weight;
evaluating to 0

Causing LASSERT(hrp->hrp_nthrs > 0); to trigger

Patch
http://review.whamcloud.com/#/c/19106/

attempts to resolve this issue.



 Comments   
Comment by Joseph Gmitter (Inactive) [ 01/Aug/16 ]

Hi Amir,

Can you please review Oleg's comments in the patch?

Thanks.
Joe

Generated at Sat Feb 10 02:17:39 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.