[LU-8499] wireshark plugins don't build any more Created: 11/Aug/16 Updated: 22/Sep/16 Resolved: 22/Sep/16 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.9.0 |
| Fix Version/s: | Lustre 2.9.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Kit Westneat | Assignee: | Kit Westneat |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Severity: | 3 | ||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||
| Description |
|
Patch e14246641c04c9e3004043f58f469532223d06d6 added some code to the wireshark plugin to handle the new ladvise feature, but the changes appear to have broken the wireshark build. On a side note, would it be possible to add a wireshark compile to the jenkins build so that there is coverage? |
| Comments |
| Comment by Doug Oucharek (Inactive) [ 11/Aug/16 ] |
|
It would be better if our dissectors were pushed upstream to the Wireshark repo so it can evolve independently of Lustre. |
| Comment by Andreas Dilger [ 12/Aug/16 ] |
|
Doug, IU is currently working to update the wireshark dissectors for the Shared Secret Key feature, and I've asked them to submit the code upstream to the wireshark project. Even if the upstream code is a bit harder to update when changes are made in Lustre, the truth is that the wireshark code was never really kept up-to-date even when it was part of the Lustre tree. At least this way anyone using wireshark will get reasonably good Lustre decoding out of the box without having to patch and compile it themselves, and it probably won't be significantly more outdated than what is in the tree today. Kit, it probably makes sense for you to use the IU version of the wireshark plugin. |
| Comment by Andreas Dilger [ 12/Aug/16 ] |
|
Kit, can you please provide more detail of what problem you are seeing, and ideally a minimal fix to land to master in advance of the larger IU changes. That said, even if IU is sending the updated wireshark plugin to the upstream wireshark maintainers, it would still be a good idea to also land those changes to the Lustre tree so that the updated dissector is available for anyone not using the latest wireshark, or in case it isn't merged upstream promptly. |
| Comment by Gerrit Updater [ 23/Aug/16 ] |
|
Kit Westneat (kit.westneat@gmail.com) uploaded a new patch: http://review.whamcloud.com/22074 |
| Comment by Gerrit Updater [ 22/Sep/16 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22074/ |
| Comment by Peter Jones [ 22/Sep/16 ] |
|
Landed for 2.9 |