[LU-8541] change lru_max_age to units of ms Created: 25/Aug/16 Updated: 02/Nov/18 Resolved: 21/Sep/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0, Lustre 2.10.2 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Andreas Dilger | Assignee: | Niu Yawei (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
Currently the ldlm.namespaces.*.lru_max_age parameter is printed in units of HZ, but that is not a useful unit of measure. Instead this should be exported to userspace in units of ms (which matches the HZ=1000 used by default on RHEL systems, so it won't be a user-visible change). The parameter read/written should be translated into units of HZ in lprocfs. It would actually be better to have this in units of seconds, but I don't think it is possible to change lru_max_age in a compatible way. Instead, a second parameter could be added like lru_max_seconds that converts from seconds to HZ to set the same parameter, but that is not very critical compared to having constant units between clients. |
| Comments |
| Comment by James A Simmons [ 07/Dec/16 ] |
|
Because of the HZ issue being different between platforms we should look to moving the code to ktime instead of jiffies. |
| Comment by Gerrit Updater [ 04/Aug/17 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/28370 |
| Comment by Gerrit Updater [ 21/Sep/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28370/ |
| Comment by Peter Jones [ 21/Sep/17 ] |
|
Landed for 2.11 |
| Comment by Gerrit Updater [ 29/Sep/17 ] |
|
Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/29265 |
| Comment by Gerrit Updater [ 11/Oct/17 ] |
|
John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/29265/ |
| Comment by Gerrit Updater [ 19/Oct/18 ] |
|
Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33406 |
| Comment by Gerrit Updater [ 02/Nov/18 ] |
|
Joseph Gmitter (jgmitter@whamcloud.com) merged in patch https://review.whamcloud.com/33406/ |