[LU-8543] ll_revalidate_dentry unsafe usage of parent inode

• Status: Open
• Project: Lustre
• Type: Bug
• Priority: Major
• Reporter: Oleg Drokin
• Assignee: Oleg Drokin
• Resolution: Unresolved
• Labels: patch
• Severity: 3

Description

Al Viro advises us that we cannot just use parent inode like that unguarded.

There are two problems.
First, by the time we get to ll_Revalidate, the parent might change since nothing locks it, but there's nothing we could do about it.
But the other problem - the parent inode could be freed while we are there and we do not hold a reference - so this should be fixed.
We should convert to something like dget_parent.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: https://review.whamcloud.com/24176
Subject: LU-8543 llite: Use dget_parent to safely access parent in revalidate
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8f101693f988d9d053e9daca5c02f972d68332d1