[LU-8561] Redundant check in osd_mount Created: 29/Aug/16 Updated: 05/Oct/16 Resolved: 05/Oct/16 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.9.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oleg Drokin | Assignee: | Jinshan Xiong (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
smatch reports that: 1030 1030 err:
1031 1031 » if (rc) {
1032 1032 » » if (o->od_os)
Misc Code Checks Robot (Gatekeeper helper) warn: osd_mount():variable dereferenced before check 'o->od_os' (see line …
Basically the problem here is o->od_os is always true. While it's possible to convert this to LASSERT, I wonder if we should just drop it altogether since there'd be crash either way. This was exposed by landing of |
| Comments |
| Comment by Gerrit Updater [ 31/Aug/16 ] |
|
Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: http://review.whamcloud.com/22245 |
| Comment by Gerrit Updater [ 05/Oct/16 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22245/ |
| Comment by Peter Jones [ 05/Oct/16 ] |
|
Landed for 2.9 |