|
Originally, I was trying to fix a couple of "which" checks in init_test_env() in Orion to run only on servers. It quickly turned out that server nodes are unknown in init_test_env(), because configuration files are loaded after init_test_env(). Looking through the code to see if a reorder is possible, I was impressed (again) by how messy the configuration file and Test Framework initialization have become. It is difficult to see where the default value of an environment variable is determined. It is sometimes hard to find places to add verifications for environment variables. (See LU-427.)
I think we should clean up at least the initialization code to load configuration files before init_test_env(). Ideally, we could clean up the configuration files as well, so that default values are determined only within init_test_env(), leaving only simple assignments in the configuration files.
|