[LU-8654] obd_connect_data handling must account for clients that send obd_connect_data_v1 Created: 30/Sep/16  Updated: 08/Oct/16  Resolved: 08/Oct/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.9.0
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Blocker
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-5560 SELinux support on the client side Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Before 2.7.50 clients will send a struct obd_connect_data_v1 rather than a
full struct obd_connect_data. So care must be taken when accessing fields
that are not present in struct obd_connect_data_v1. For example in mdt_connect_internal() when we clear ocd_connect_flags2 we may be writing past the end of the request field buffer:

        data->ocd_connect_flags &= MDT_CONNECT_SUPPORTED;
        data->ocd_connect_flags2 &= MDT_CONNECT_SUPPORTED2;


 Comments   
Comment by Gerrit Updater [ 30/Sep/16 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/22837
Subject: LU-8654 obd: access ocd_connect_flags2 only when present
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ad0d8245d207fe6af343556b485d811287032879

Comment by Gerrit Updater [ 08/Oct/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22837/
Subject: LU-8654 obd: access ocd_connect_flags2 only when present
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c7ede9238c24b8187ee38c80d5b680c8a5a8e703

Comment by Peter Jones [ 08/Oct/16 ]

Landed for 2.9

Generated at Sat Feb 10 02:19:25 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.