[LU-8672] missing error handling in replay-single test_89 Created: 06/Oct/16 Updated: 03/Mar/18 Resolved: 03/Mar/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Ashish Purkar (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Issue Links: |
|
||||||||||||||||
| Severity: | 3 | ||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
replay-single test_89() does not error out on wait_mds_ost_sync and wait_delete_complete() depends on the return code from wait_delete_completed_mds(), however wait_delete_completed_mds() does not return error code (non-zero) in case it could not wait until delete to be completed for some reason. This could mislead to test failure of mismatched block and suppress actual root cause. wait_delete_completed() {
wait_delete_completed_mds $1 || return $? <<<<< problem: wait_delete_completed does not actually return error code
wait_destroy_complete
}
Ideally we need to know if wait_delete_completed_mds() failed. |
| Comments |
| Comment by Gerrit Updater [ 06/Oct/16 ] |
|
Ashish Purkar (ashish.purkar@seagate.com) uploaded a new patch: http://review.whamcloud.com/22974 |
| Comment by Andreas Dilger [ 04/Jan/18 ] |
|
This may also help to fix intermittent failures in replay-single test_20b reported in |
| Comment by James Nunez (Inactive) [ 18/Jan/18 ] |
|
Unfortunately, this patch did not fix the replay-single test 20b failure because this patch hit that failure. See https://testing.hpdd.intel.com/test_sets/bbe57164-f9e6-11e7-bd00-52540065bddc |
| Comment by Gerrit Updater [ 03/Mar/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/22974/ |
| Comment by Peter Jones [ 03/Mar/18 ] |
|
Landed for 2.11 |