[LU-8697] remove IS_ERR(master_inode) check.

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: Di Wang
• Assignee: James A Simmons
• Resolution: Fixed
• Severity: 3

Description

The patch 2de353860782: "staging: lustre: create striped directory"
from Aug 16, 2016, leads to the following static checker warning:

drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast()
warn: 'master_inode' isn't an ERR_PTR

drivers/staging/lustre/lustre/llite/namei.c
287
288 hash =
cl_fid_build_ino(&lli->lli_pfid,
289
ll_need_32bit_api(ll_i2sbi(inode)));
290
291 master_inode =
ilookup5(inode->i_sb, hash,
292
ll_test_inode_by_fid,
293 (void
*)&lli->lli_pfid);
294 if (master_inode &&
!IS_ERR(master_inode)) {

^^^^^^^^^^^^^^^^^^^^
ilookup5() never returns ERR_PTRs.

Comments

[Oleg Drokin]

this is the case in upstream kernel, need to see if this is the case in our other supported kernels like rhel6 and rhel7

[James A Simmons]

Thanks Oleg/WiDang for filing this.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/23151
Subject: LU-8697 llite: remove IS_ERR(master_inode) check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 286224f8c542cf8f1ebae16e932d1062cc0e8bda

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/23151/
Subject: LU-8697 llite: remove IS_ERR(master_inode) check
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 84f6e2cd3db3ea29b23ae16d767573d5544d88bd

[Peter Jones]

Landed for 2.9