[LU-8700] dkms fails to build lustre on Power8 due to llite_loop missing Created: 13/Oct/16  Updated: 12/Nov/16  Resolved: 07/Nov/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.8.0, Lustre 2.9.0
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Major
Reporter: James A Simmons Assignee: Bruno Faccini (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

Power8 clients running RHEL7.


Issue Links:
Related
is related to LU-6387 Add Power8 support to Lustre Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

On the Power8 platform the llite_loop device is not built but the dkms spec files expect that the llite_loop.ko is present. This causes lustre to fail to install using dkms on Power8 clients.



 Comments   
Comment by Andreas Dilger [ 13/Oct/16 ]

Since llite_loop was already removed in the upstream kernel, it makes sense just to delete it and the test(s) that reference it from master as well.

Comment by Bruno Faccini (Inactive) [ 13/Oct/16 ]

This should be handled in dkms.mkconf during on-target configure step. I will cook a patch to implement it.

Comment by Bruno Faccini (Inactive) [ 14/Oct/16 ]

I understand that llite_lloop.ko is not built for Power8 platform due to PAGE_SIZE == 65536, but I wonder if, due to its specific purpose/usage, it is not just/simply ok to ignore it during DKMS Client builds. On the other hand, in dkms.mkconf, do we need to find the PAGE_SIZE for the Kernel we build against (quite easy to implement) or just determine if it is a Lustre Server/Client build/package (much more easy!!) ??

Comment by Gerrit Updater [ 18/Oct/16 ]

Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/23228
Subject: LU-8700 build: dkms only build llite_lloop for servers
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2380750551c03a312e5abf5b010c3d5213292e70

Comment by Bruno Faccini (Inactive) [ 20/Oct/16 ]

Well in fact seems that I have misunderstood llite_lloop.ko module's features/usages, and its is mostly being used for Clients as it is mainly allowing Clients to use a Lustre file as a block-device (for example as their swap-device for diskless Clients, ...).
So I will modify my Gerrit-change #23228 to allow DKMS to build/create llite_lloop.ko module for/on both Lustre Clients and Servers, but only if their PAGE_SIZE < 65536.

Comment by Bruno Faccini (Inactive) [ 24/Oct/16 ]

Gerrit-change #23228 now simply always ignore llite_lloop.ko module in DKMS.

Comment by Gerrit Updater [ 07/Nov/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/23228/
Subject: LU-8700 build: dkms do not install llite_lloop
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 21bed01ff234a239e4b044b099d53ba2fe7ca24a

Comment by Peter Jones [ 07/Nov/16 ]

Landed for 2.9

Generated at Sat Feb 10 02:19:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.