[LU-8708] Grant shrinking disabled all the time Created: 13/Oct/16  Updated: 04/Feb/20  Resolved: 01/Sep/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.12.0

Type: Improvement Priority: Critical
Reporter: Oleg Drokin Assignee: Zhenyu Xu
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocker
Related
is related to LU-3859 grant shrinker floods OST and produce... Resolved
is related to LU-11288 tgt_grant_sanity_check()) LBUG Resolved
is related to LU-12651 High kworker CPU usage (osc_grant_wor... Resolved
is related to LU-8895 server grants clients with more grant... Resolved
is related to LU-10990 Get rid of per-osc max_dirty_mb setting Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

It appears that OBD_CONNECT_GRANT_SHRINK is not set by client at all. It was disabled all the way back in 1.8.1 time due to bz 19507 "for debugging" and never reenabled. Commit a3c09ef128651a8f041171f2d6099b3ba8d8f2c6.

I guess that was an omission and we should reenable it back?
Do we still need it in master in light of grant_param stuff? I think we still do?

 Comments   
Comment by Malcolm Cowe (Inactive) [ 14/Oct/16 ]

Possibly unrelated, but back in the 1.8.x releases, there were issues with grant leaks, where the workaround was to increase the grant interval before it was ultimately fixed (BZ 22755. The following thread summarises the original issue:

https://groups.google.com/forum/#!topic/lustre-discuss-list/4szexbm2HV0

Comment by Andreas Dilger [ 14/Oct/16 ]

This was disabled in https://bugzilla.lustre.org/show_bug.cgi?id=19507

Comment by Joseph Gmitter (Inactive) [ 14/Oct/16 ]

Hi Bobijam,

Can you please look into this issue for 2.10?

Thanks.
Joe

Comment by Andreas Dilger [ 14/Oct/16 ]

It looks like https://bugzilla.lustre.org/attachment.cgi?id=24058 was never landed and may be a good starting point.

Comment by Gerrit Updater [ 17/Oct/16 ]

Bobi Jam (bobijam@hotmail.com) uploaded a new patch: http://review.whamcloud.com/23202
Subject: LU-8708 osc: depart grant shrinking from pinger
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7fb9d398769775c7d61a8151b88508524a7cf07b

Comment by Gerrit Updater [ 17/Oct/16 ]

Bobi Jam (bobijam@hotmail.com) uploaded a new patch: http://review.whamcloud.com/23203
Subject: LU-8708 osc: enable/disable OSC grant shrink
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b3caa6fad04175b5ab388f16da3de324221f7339

Comment by Nathan Rutman [ 26/Oct/17 ]

Is this fixed for 2.11 ("Fix Version")? Last activity was a year ago...

Comment by Andreas Dilger [ 28/Oct/17 ]

Nathan, neither of these patches have landed.

Comment by Gerrit Updater [ 24/Jul/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/23202/
Subject: LU-8708 osc: depart grant shrinking from pinger
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fc915a43786eaf505be515e7e812397acd7110ee

Comment by Oleg Drokin [ 28/Aug/18 ]

This patch potentially leads to LU-11288

Comment by Gerrit Updater [ 01/Sep/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/23203/
Subject: LU-8708 osc: enable/disable OSC grant shrink
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3e070e30a98dfebb63e016c06c3054ea136149f1

Comment by Peter Jones [ 01/Sep/18 ]

Landed for 2.12

Generated at Sat Feb 10 02:19:52 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.