[LU-8737] Lustre upstream client tree for testing is wrong branch Created: 19/Oct/16 Updated: 20/Jan/17 Resolved: 25/Oct/16 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | James A Simmons | Assignee: | Minh Diep |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | None | ||
| Environment: |
lustre staging tree that gerrit uses. |
||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
Now that the upstream client is approaching the 2.8 version it is time to hook in testing setup to verify potential patches to land. When I went to check out the staging tree used for testing I noticed it is based on the wrong git tree. It needs to be based on the staging tree's staging-next branch. |
| Comments |
| Comment by Jian Yu [ 20/Oct/16 ] |
|
Hi Minh, Could you please take a look at this issue or find someone proper to resolve the issue? Thank you. |
| Comment by Minh Diep [ 21/Oct/16 ] |
|
Hi James, Could you let me know exactly what you check? More info would help me understand. Thanks |
| Comment by James A Simmons [ 24/Oct/16 ] |
|
I checked out: ssh://jsimmons@review.whamcloud.com:29418/fs/linux-staging Is this the wrong thing that I checked out? What is used for upstream lustre developement is: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Then switch to branch staging-testing |
| Comment by Minh Diep [ 25/Oct/16 ] |
|
Hi James, These are what we mirrored git remote add linux http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git I compared staging.git/staging-testing and our mirrored fs/linux-testing/staging-testing; and they seem to match. am I missing something? bddalton-mobl:staging minhdiep$ grep url .git/config url = http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git bddalton-mobl:staging minhdiep$ git lg | head * 49b9137 - (HEAD, origin/staging-testing, origin/staging-next, staging-testing, staging-next) staging: greybus: audio: remove redundant slot field (25 hours ago)<Pankaj Bharadiya> * 73270bb - Staging: Greybus: Fix trailing */ in block comments (25 hours ago)<Rahul Krishnan> * 7fec2bc - staging: greybus: es2: fix arpc request size (25 hours ago)<Rui Miguel Silva> * f9a21a3 - staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion. (25 hours ago)<Elise Lennion> * 5bc45c9d - staging: xgifb: Remove unnecessary parentheses. (25 hours ago)<Elise Lennion> * 596f144 - staging: vt6656: Remove unnecessary parentheses. (25 hours ago)<Elise Lennion> * a0f204a - Staging: android: ion: Make a read-only structure (25 hours ago)<Mihaela Muraru> * 9fdd532 - staging: android: Remove unnecessary parentheses. (25 hours ago)<Elise Lennion> * f9bee6d - staging: vc04_services: Add casts to remove warnings in vchiq_core.c (26 hours ago)<Michael Zoran> * 8e8e2e3 - staging: vc04_services: Handle conversion from VCHIQ_SERVICE_HANDLE_T to VCHI_SERVICE_HANDLE_T (26 hours ago)<Michael Zoran> hgyoo-mobl3:linux-staging minhdiep$ grep url .git/config url = ssh://mdiep@review.whamcloud.com:29418/fs/linux-staging hgyoo-mobl3:linux-staging minhdiep$ git lg | head * 49b9137 - (HEAD, origin/staging-testing, origin/staging-next, staging-testing, staging-next) staging: greybus: audio: remove redundant slot field (25 hours ago)<Pankaj Bharadiya> * 73270bb - Staging: Greybus: Fix trailing */ in block comments (25 hours ago)<Rahul Krishnan> * 7fec2bc - staging: greybus: es2: fix arpc request size (25 hours ago)<Rui Miguel Silva> * f9a21a3 - staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion. (25 hours ago)<Elise Lennion> * 5bc45c9d - staging: xgifb: Remove unnecessary parentheses. (25 hours ago)<Elise Lennion> * 596f144 - staging: vt6656: Remove unnecessary parentheses. (25 hours ago)<Elise Lennion> * a0f204a - Staging: android: ion: Make a read-only structure (25 hours ago)<Mihaela Muraru> * 9fdd532 - staging: android: Remove unnecessary parentheses. (25 hours ago)<Elise Lennion> * f9bee6d - staging: vc04_services: Add casts to remove warnings in vchiq_core.c (26 hours ago)<Michael Zoran> * 8e8e2e3 - staging: vc04_services: Handle conversion from VCHIQ_SERVICE_HANDLE_T to VCHI_SERVICE_HANDLE_T (26 hours ago)<Michael Zoran> |
| Comment by James A Simmons [ 25/Oct/16 ] |
|
Ah I didn't know that you mirror several branches. So I did a checkout of the staging-testing branch. Its correct now. lustre-upstream$ git push ssh://jsimmons@review.whamcloud.com:29418/fs/linux-staging HEAD:refs/heads/staging-testing |
| Comment by Minh Diep [ 25/Oct/16 ] |
|
I would think you should use HEAD:refs/for/staging-testing to push for review; and which will trigger a build and test |
| Comment by James A Simmons [ 25/Oct/16 ] |
|
You are right. I'm a idiot. I just pushed the patch. It works: |
| Comment by Peter Jones [ 25/Oct/16 ] |
|
Don't be so hard on yourself James |
| Comment by James A Simmons [ 25/Oct/16 ] |
|
Minh I noticed a few oddities with the pushed patch. The Intel-bug-id: url seems to have gotten mangled. The jenkins build links is also invalid. Lastly do you think it would be possible to get linux/scripts/checkpatch to run against the patch and report the result. Thanks Peter |
| Comment by Minh Diep [ 25/Oct/16 ] |
|
I will look into the commit message being mangled; and checkpatch . The jenkins build links should be accessible now |
| Comment by James A Simmons [ 25/Oct/16 ] |
|
Yep Jenkins passed. Now for the checkpatch and commit message issue. |
| Comment by James A Simmons [ 20/Jan/17 ] |
|
From Doug's latest patch that was pushed it appears that the commit message issues has been fixed. Does checkpatch run against a submitted patch. Also it looks like the test suite is run against staging-testing branch which is correct. We are making progress. |