[LU-8744] Count the journal credits in case of indirect bitmap correctly. Created: 20/Oct/16  Updated: 09/Feb/17  Resolved: 23/Oct/16

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Yang Sheng Assignee: Yang Sheng
Resolution: Not a Bug Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The commit 85c6c099d83b19480dd4160de57e7ffac5b312af has a typo in condition.

	} else if (pos + size <= (LDISKFS_NDIR_BLOCKS + 1024) * bs) {
		/* single indirect */
		credits = blocks * 3;
		if (inode == NULL ||
>>>>>>>	    LDISKFS_I(inode)->i_data[LDISKFS_IND_BLOCK] == 0)
			credits += 3;
		else
			/* The indirect block may be modified. */
			credits += 1;
	}

It causes the issue that insufficient journal credit in some case



 Comments   
Comment by Gerrit Updater [ 20/Oct/16 ]

Yang Sheng (yang.sheng@intel.com) uploaded a new patch: http://review.whamcloud.com/23294
Subject: LU-8744 osd-ldiskfs: count journal credit correctly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6dba7893a8d6e409401322701ade02180f2a22db

Generated at Sat Feb 10 02:20:11 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.