[LU-8767] Improve proc file text in lproc_llite.c Created: 27/Oct/16  Updated: 23/Feb/17  Resolved: 23/Feb/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.10.0

Type: Bug Priority: Trivial
Reporter: Steve Guminski (Inactive) Assignee: Steve Guminski (Inactive)
Resolution: Fixed Votes: 0
Labels: easy

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Several improvements were suggested in LU-8186 for the text displayed in the /proc/fs/lustre/llite/.../extents_stats* files. The relevant text occurs multiple times in lustre/llite/lproc_llite.c:

seq_puts(seq, "disabled\n write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n");

The following changes should be made to all occurrences of the text:

  • Use single quotes to avoid the need for escapes.
  • Simplify the message by only mentioning "disabled" with lower case, and silently continue to accept "Disabled".
  • Use a | to separate the two options to be consistent with accepted usage.
  • Replace "in this file" with "to this file"

 Comments   
Comment by Gerrit Updater [ 24/Nov/16 ]

Steve Guminski (stephenx.guminski@intel.com) uploaded a new patch: http://review.whamcloud.com/23942
Subject: LU-8767 llite: Improve proc file text in lproc_llite.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2c5a9f92766894d10437633e59d90ccbb77bc69b

Comment by Gerrit Updater [ 23/Feb/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/23942/
Subject: LU-8767 llite: Improve proc file text in lproc_llite.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8d27681c98b2e702b2d3ea7fc603e21c444f7590

Comment by Peter Jones [ 23/Feb/17 ]

Landed for 2.10

Generated at Sat Feb 10 02:20:22 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.