[#LU-8769] Remove obsolete LND types

[LU-8769] Remove obsolete LND types Created: 27/Oct/16 Updated: 07/Feb/17 Resolved: 07/Feb/17
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Lustre 2.10.0

Type:

Bug

Priority:

Trivial

Reporter:

Steve Guminski (Inactive)

Assignee:

Sonia Sharma (Inactive)

Resolution:

Fixed

Votes:

Labels:

easy

Severity:

Rank (Obsolete):

9223372036854775807

Description

There are several LND types that are no longer in use, and should be removed. The LND types are initialized in this array in libcfs/libcfs/util/nidstrings.c:

static struct netstrfns libcfs_netstrfns[]

The following LNDs should be removed:

CIBLND
OPENIBLND
IIBLND
VIBLND
RALND
QSWLND
GMLND
MXLND
PTLLND

Comments

Comment by Andreas Dilger [ 27/Oct/16 ]

Note that some of the LNDs were only recently removed (after 2.5) and at least the name->network mapping should stick around in order for a client/server to route to that network type (e.g. on a Cray cluster running an older version of Lustre that connects to newer servers), even if it doesn't have support for the network locally. The other IBLND and GMLND types are have not been used for ages so it isn't a concern and they can be removed completely. Please keep commented-out definitions in lnet/include/lnet/nidstr.h (the unnamed enum, that should really get a name like enum lnet_types so that this can properly be used elsewhere in the code) to avoid re-using these values:

enum lnet_types {    
        /* Only add to these values (i.e. don't ever change or redefine them):
         * network addresses depend on them... */ 
        QSWLND          = 1, /* removed v2_7_50_0-34-g8be9e41 */
        SOCKLND         = 2,    
        /* GMLND        = 3,    removed v2_0_0-rc1a-16-gc660aac */
        PTLLND          = 4, /* removed v2_5_53_0-21-g61bcfb2 */
        O2IBLND         = 5,    
        /* CIBLND       = 6,    removed v2_0_0-rc1a-175-gd2b8a0e */
        /* OPENIBLND    = 7,    removed v2_0_0-rc1a-175-gd2b8a0e */
        /* IIBLND       = 8,    removed v2_0_0-rc1a-175-gd2b8a0e */
        LOLND           = 9,    
        RALND           = 10, /* removed v2_7_50_0-34-g8be9e41 */
        /* VIBLND       = 11,   removed v2_0_0-rc1a-175-gd2b8a0e */
        MXLND           = 12, /* removed v2_7_50_0-34-g8be9e41 */
        GNILND          = 13,
        GNIIPLND        = 14,
};

If you are removing the remaining LNDs, please also look at removing the rest of the places where these constants are used (headers, Makefile.*, autoconf, etc). Run e.g. git grep VIBLND to see all of the places this is used.

Comment by Patrick Farrell (Inactive) [ 01/Nov/16 ]

FWIW, speaking for Cray, the PTLLND line can be completely commented out. We are confident about never running 2.9 or 2.10 on anything that has a connection with a PTLLND system.

Comment by Joseph Gmitter (Inactive) [ 03/Nov/16 ]

Hi Sonia,

Would you be able to assess these LND's for possible removal?

Thanks.
Joe

Comment by Andreas Dilger [ 03/Nov/16 ]

Just to clarify, the LNDs were removed long ago. All that this ticket is about is removing the name<->network number mapping for these obsolete LNDs, and (preferably, as stated above) adding clear comments for the removed LND network numbers.