[LU-8776] fix weird inline definitions

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.9.0
• Fix Version/s: Lustre 2.10.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: Steve Guminski (Inactive)
• Resolution: Fixed
• Labels: easy
• Severity: 3

Description

There are a number of functions defined inline or 'inline static'.

lnet/klnds/gnilnd/gnilnd_cb.c-304-
lnet/klnds/gnilnd/gnilnd_cb.c:305:inline __u16
lnet/klnds/gnilnd/gnilnd_cb.c-306-kgnilnd_cksum_kiov(unsigned int nkiov, lnet_kiov_t *kiov,
--
lnet/klnds/gnilnd/gnilnd_cb.c-1658-/* lets us know if we can push this RDMA through now */
lnet/klnds/gnilnd/gnilnd_cb.c:1659:inline int
lnet/klnds/gnilnd/gnilnd_cb.c-1660-kgnilnd_auth_rdma_bytes(kgn_device_t *dev, kgn_tx_t *tx)
--
lustre/contrib/wireshark/packet-lustre.c-1306-/* @gint col :  the col where we add the information */
lustre/contrib/wireshark/packet-lustre.c:1307:inline static void display_info_str(proto_item *pi, column_info *cinfo, gint col, const gchar* str)
lustre/contrib/wireshark/packet-lustre.c-1308-{
--
lustre/obdclass/genops.c-1932-/* Takes pointer to payload area */
lustre/obdclass/genops.c:1933:inline void kuc_free(void *p, int payload_len)
lustre/obdclass/genops.c-1934-{
--
lustre/utils/gss/write_bytes.h-37-
lustre/utils/gss/write_bytes.h:38:inline static int
lustre/utils/gss/write_bytes.h-39-write_bytes(char **ptr, const char *end, const void *arg, int arg_len)
--
lustre/utils/gss/write_bytes.h-52-
lustre/utils/gss/write_bytes.h:53:inline static int
lustre/utils/gss/write_bytes.h-54-write_buffer(char **p, char *end, gss_buffer_desc *arg)
--
lustre/utils/gss/write_bytes.h-65-
lustre/utils/gss/write_bytes.h:66:inline static int
lustre/utils/gss/write_bytes.h-67-write_oid(char **p, char *end, gss_OID_desc *arg)

These should be converted to 'static inline', 'static', or just given default linkage where appropriate.

Issue Links

• is related to: LU-6387 Add Power8 support to Lustre

Comments

[Joseph Gmitter (Inactive)]

Hi Steve,

Can you please have a look at this one?

Thanks.
Joe

[Steve Guminski (Inactive)]

Sure, I'll add this to my queue.

[Gerrit Updater]

Steve Guminski ([e-mail]) uploaded a new patch: http://review.whamcloud.com/23979
Subject: LU-8776 build: Fix weird inline definitions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d04affefbe452b87bcea01d45c578f49b69ecb15

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/23979/
Subject: LU-8776 build: Fix weird inline definitions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c09317f0ba07bc7c9af229b9bfb166be56792bbf

[Peter Jones]

Landed for 2.10