[LU-8779] llapi_hsm_log_ct_progress incorrect indenting

• Status: Closed
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: Alex Zhuravlev
• Resolution: Duplicate
• Labels: easy
• Severity: 3

Description

Building on Fedora, we get this build error:

liblustreapi_hsm.c: In function Б─≤llapi_hsm_log_ct_progressБ─≥:
liblustreapi_hsm.c:432:2: error: this Б─≤ifБ─≥ clause does not guard... [-Werror=misleading-indentation]
  if (progress_type == CT_RUNNING)
  ^~
liblustreapi_hsm.c:435:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the Б─≤ifБ─≥
   if (rc < 0)
   ^~

The code looks like this:

        if (progress_type == CT_RUNNING)
                rc = llapi_json_add_item(&json_items, "current_bytes",
                                         LLAPI_JSON_BIGNUM, &current);
                if (rc < 0)
                        goto err;

I guess in that place it does not matter if we fix the indenting ot add extra parenthesis, but something need to be done to avoid confusion.

Comments

[Alex Zhuravlev]

http://review.whamcloud.com/#/c/22348/

[Alex Zhuravlev]

a dup of LU-8587