[LU-881] shmem_bump() notes "running" bumped without lock control Created: 28/Nov/11  Updated: 27/Mar/12  Resolved: 08/Dec/11

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 1.8.x (1.8.0 - 1.8.5)
Fix Version/s: Lustre 2.2.0

Type: Bug Priority: Minor
Reporter: Bruce Korb (Inactive) Assignee: Robert Read (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

all

Severity: 3
Rank (Obsolete): 4836

 Description   

This code allows "running" to be bumped once for each
thread that enters "lock()" before "bumped_running"
gets set to 1. This has been simplified from code in obd.c:

static int bumped_running;
lock();
if (!bumped_running)
running++;
unlock();
bumped_running = 1;

 Comments   
Comment by Bruce Korb (Inactive) [ 28/Nov/11 ]

Review board link: http://review.whamcloud.com/#change,1749

Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » i686,client,el5,ofa #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Build Master (Inactive) [ 07/Dec/11 ]

Integrated in lustre-master » i686,server,el5,ofa #370
LU-881 utils: running bumped w/o lock (Revision 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794)

Result = SUCCESS
Oleg Drokin : 9b62cf1f91bf50eaf5e1ef63024b2b6f78f28794
Files :

  • lustre/utils/obd.c
Comment by Peter Jones [ 08/Dec/11 ]

Landed for 2.2

Generated at Sat Feb 10 01:11:18 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.