[LU-8942] bad test in sanityn test_80b

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: James Nunez (Inactive)
• Resolution: Duplicate
• Labels: test, test_script_improvements
• Severity: 3

Description

In sanityn test_80b() the condition rc != 0 || rc != 16 is true for all values of rc:

         	while true; do
                        mdt_idx=$((RANDOM % MDSCOUNT))
			$LFS migrate -m $mdt_idx $migrate_dir1 2&>/dev/null ||
                                rc=$?
			[ $rc -ne 0 -o $rc -ne 16 ] || break
                done

Some grepping turned up three more tests:

lustre-release$ git grep --line-number -E '\$[^ ]+ -ne 0 -o \$[^ ]+ -ne '
lustre/tests/sanityn.sh:3448:                   [ $rc -ne 0 -o $rc -ne 16 ] || break
lustre/tests/sanityn.sh:3483:           [ $rc1 -ne 0 -o $rc1 -ne 1 ] || {
lustre/tests/sanityn.sh:3497:                   [ $rc1 -ne 0 -o $rc1 -ne 1 ] || {
lustre/tests/sanityn.sh:3509:                   [ $rc1 -ne 0 -o $rc1 -ne 1 ] || {

Issue Links

• is related to: LU-8845 sanityn test_80b: test failed to resp...
• is related to: LU-15358 Fix shellcheck errors

Comments

[James Nunez (Inactive)]

A patch for this bad check is at https://review.whamcloud.com/46706 submitted under LU-15358.