[LU-8958] remove code left unused after lloop removal Created: 19/Dec/16 Updated: 16/Mar/18 Resolved: 05/Aug/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.10.1, Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | James A Simmons |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
There is a fair amount of easy cleanup that can be done now that lloop has been removed. The LL_MRF_RETURN macros can be removed. Several autoconf defines/checks are no longer referenced: HAVE_QC_MAKE_REQUEST_FN HAVE_VOID_MAKE_REQUEST_FN HAVE_BIO_ENDIO_USES_ONE_ARG HAVE_REQUEST_QUEUE_UNPLUG_FN HAVE_BLKDEV_RELEASE_RETURN_INT ll_iocontrol_register(), ll_iocontrol_unregister(), ll_iocontrol_call(), and the llioc* structures can be removed. ll_direct_rw_pages() is not longer used outside of llite and should be merged with ll_direct_IO_seg(). struct ll_dio_pages() can be removed. In sanity.sh the LLOOP and LLITELOOPLOAD variables and the function cleanup_68() are unused. |
| Comments |
| Comment by Gerrit Updater [ 24/Apr/17 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/26795 |
| Comment by Gerrit Updater [ 05/Aug/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/26795/ |
| Comment by Gerrit Updater [ 05/Sep/17 ] |
|
Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/28860 |
| Comment by Gerrit Updater [ 14/Sep/17 ] |
|
John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/28860/ |
| Comment by Jinshan Xiong [ 12/Mar/18 ] |
|
Hi Simmons, have you noticed that the kernel's loop device can't do direct IO over 64KB, and it seems there is no way to increase the size of max_sectors_size, etc. Not sure if you have done this before but please let me know if I missed something |
| Comment by James A Simmons [ 16/Mar/18 ] |
|
I can ask the VFS guys about this. I have to ask why the interest in this? Originally the only use of llite_lloop was for running swap on a lustre mount. |
| Comment by Jinshan Xiong [ 16/Mar/18 ] |
|
Potentially this would be good to support access to bunch of small files. |