[LU-9091] Replace lprocfs_str_with_units_to_s64 with string_get_size() Created: 08/Feb/17  Updated: 13/Nov/20  Resolved: 31/Mar/20

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.14.0

Type: Improvement Priority: Minor
Reporter: James A Simmons Assignee: James A Simmons
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Related
is related to LU-8066 Move lustre procfs handling to sysfs ... Open
is related to LU-7334 Refactor lprocfs helpers Resolved
is related to LU-10517 setting llite.*.checksum_pages doesn'... Resolved
is related to LU-11157 sanity test_42e: invalid arithmetic o... Resolved
is related to LU-12511 Prepare lustre for adoption into the ... Open
Rank (Obsolete): 9223372036854775807

 Description   

The latest kernels have introduced a function that is very similar to what was done in LU-7334. The difference is the unit labels i.e M instead of MB. Upstream will be wanting us to use this standard function.



 Comments   
Comment by Gerrit Updater [ 14/Dec/17 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/30539
Subject: LU-9091 obd: replace lprocfs_str_to_s64
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8e442396d9a2c6686b2e3aa3db889f03358e522a

Comment by Gerrit Updater [ 22/Feb/18 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/31380
Subject: LU-9091 tests: use upstream units for proc settings
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e8cc6cf7f2cdd3bf3a96a28b89eb60764d7b5573

Comment by Gerrit Updater [ 31/Jul/19 ]

James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/35658
Subject: LU-9091 sysfs: use string helper like functions for sysfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 50f7e2f2a60b0f2d6ccb6043de6c2f3a7e542e7e

Comment by Gerrit Updater [ 10/Jan/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35658/
Subject: LU-9091 sysfs: use string helper like functions for sysfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d9e0c9f346d0f0cccfa37737807d6f9d08255ab7

Comment by Peter Jones [ 10/Jan/20 ]

Landed for 2.14

Comment by James A Simmons [ 10/Jan/20 ]

Another patch is needed as well as a final cleanup patch.

Comment by Gerrit Updater [ 18/Jan/20 ]

James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37274
Subject: LU-9091 obd: move remaining sysfs that needs units to sysfs_memparse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5a13c7eccc3df9f34d2088cdaa0a9439b4286c05

Comment by James A Simmons [ 19/Jan/20 ]

https://review.whamcloud.com/#/c/34849

https://review.whamcloud.com/#/c/37275

Comment by Gerrit Updater [ 19/Feb/20 ]

James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37622
Subject: LU-9091 sysfs: add memparse format support for defunit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 63b1825928c5f7d6ed8bc906d5983c71a9d74c54

Comment by Gerrit Updater [ 24/Mar/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37620/
Subject: LU-9091 obdclass: allow bare KMGTPE param suffix
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d105cc4a6448b3c842790d0e1f0380b94d087f6f

Comment by Peter Jones [ 24/Mar/20 ]

Seems to have all landed for 2.14

Comment by James A Simmons [ 24/Mar/20 ]

One last cleanup patch to land - https://review.whamcloud.com/#/c/37275/

Comment by Gerrit Updater [ 31/Mar/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37275/
Subject: LU-9091 procfs: remove old string parsing routines
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 48242f98c3add59d9e084d73057e64265230a19f

Comment by Peter Jones [ 31/Mar/20 ]

Finally?

Comment by James A Simmons [ 31/Mar/20 ]

Yep its finished!!!

Generated at Sat Feb 10 02:23:10 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.