[LU-9126] Many items in ofd stats are duplicated Created: 15/Feb/17  Updated: 29/Mar/18

Status: Open
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Emoly Liu Assignee: Emoly Liu
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Our customer reported in SFW-18 that there were two statfs items in his /proc/fs/lustre/obdfilter/home-OST0000/stats, as follows:

[root@mt2-oss2 sfw]# cat /proc/fs/lustre/obdfilter/home-OST0001/stats           snapshot_time             1486566381.792281 secs.usecs
read_bytes                1478938 samples [bytes] 4096 1048576 1550225682432
write_bytes               1069208 samples [bytes] 16 1048576 1117446130583
setattr                   461 samples [reqs]
punch                     331 samples [reqs]
sync                      1900 samples [reqs]
destroy                   617 samples [reqs]
create                    10 samples [reqs]
statfs                    180993 samples [reqs]
get_info                  54 samples [reqs]
set_info_async            1 samples [reqs]
connect                   60 samples [reqs]
disconnect                1 samples [reqs]
statfs                    73400 samples [reqs]
preprw                    2548146 samples [reqs]
commitrw                  2548146 samples [reqs]
ping                      164865 samples [reqs]

Then I tried to list all the items and found many of them are duplicated, as follows:

snapshot_time             1487131084.351638 secs.usecs
read_bytes                0 samples [bytes]
write_bytes               0 samples [bytes]
getattr                   0 samples [reqs]
setattr                   0 samples [reqs]
punch                     0 samples [reqs]
sync                      0 samples [reqs]
destroy                   0 samples [reqs]
create                    2 samples [reqs]
statfs                    9 samples [reqs]
get_info                  1 samples [reqs]
set_info                  0 samples [reqs]
quotactl                  0 samples [reqs]
iocontrol                 0 samples [reqs]
get_info                  0 samples [reqs]
set_info_async            3 samples [reqs]
setup                     0 samples [reqs]
precleanup                0 samples [reqs]
cleanup                   0 samples [reqs]
process_config            0 samples [reqs]
postrecov                 0 samples [reqs]
add_conn                  0 samples [reqs]
del_conn                  0 samples [reqs]
connect                   2 samples [reqs]
reconnect                 0 samples [reqs]
disconnect                0 samples [reqs]
fid_init                  0 samples [reqs]
fid_fini                  0 samples [reqs]
fid_alloc                 0 samples [reqs]
statfs                    0 samples [reqs]
statfs_async              0 samples [reqs]
create                    0 samples [reqs]
destroy                   0 samples [reqs]
setattr                   0 samples [reqs]
getattr                   0 samples [reqs]
preprw                    0 samples [reqs]
commitrw                  0 samples [reqs]
init_export               0 samples [reqs]
destroy_export            0 samples [reqs]
import_event              0 samples [reqs]
notify                    0 samples [reqs]
health_check              0 samples [reqs]
get_uuid                  0 samples [reqs]
quotactl                  0 samples [reqs]
ping                      4 samples [reqs]
pool_new                  0 samples [reqs]
pool_del                  0 samples [reqs]
pool_add                  0 samples [reqs]
pool_rem                  0 samples [reqs]
getref                    0 samples [reqs]
putref                    0 samples [reqs]

I will create a patch to fix that.



 Comments   
Comment by Emoly Liu [ 29/Mar/18 ]

The stats items are from the following two functions:

  • ofd_procfs_init()->lprocfs_alloc_obd_stats()
  • ofd_stats_counter_init()

The duplicated items include:

  • getattr
  • setattr
  • getinfo
  • create
  • destroy
  • statfs
Generated at Sat Feb 10 02:23:28 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.