[LU-9166] missing trailing newlines in mdt/*/hsm/policy and mdd/*/changelog_mask Created: 28/Feb/17  Updated: 19/Apr/17  Resolved: 19/Apr/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.10.0

Type: Bug Priority: Minor
Reporter: John Hammond Assignee: Steve Guminski (Inactive)
Resolution: Fixed Votes: 0
Labels: easy

Issue Links:
Related
is related to LU-7092 Interop 2.7.0<->master sanity test_13... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   
x:~# cat /proc/fs/lustre/mdt/lustre-MDT0000/hsm/policy
NonBlockingRestore [NoRetryAction]x:~# 
x:~# cat /proc/fs/lustre/mdd/lustre-MDT0000/changelog_mask
MARK CREAT MKDIR HLINK SLINK MKNOD UNLNK RMDIR RENME RNMTO OPEN CLOSE LYOUT TRUNC SATTR XATTR HSM MTIME CTIME MIGRT x:~# 

We should also add a test to sanity to check that all readable non-empty proc files have a trailing newline (except possibly for a short list of known exceptions). A missing trailing newline doesn't look nice has has been known to confuse test scripts.



 Comments   
Comment by Joseph Gmitter (Inactive) [ 01/Mar/17 ]

Hi Steve,

Could you add this to your queue as well?

Thanks.
Joe

Comment by Steve Guminski (Inactive) [ 01/Mar/17 ]

Sure.

Comment by Gerrit Updater [ 14/Mar/17 ]

Steve Guminski (stephenx.guminski@intel.com) uploaded a new patch: https://review.whamcloud.com/25977
Subject: LU-9166 mdt: Add trailing newlines to proc files
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d7e17bfa78c641df310b7ac1a8ec90667e9c03e5

Comment by Gerrit Updater [ 19/Apr/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/25977/
Subject: LU-9166 mdt: Add trailing newlines to proc files
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 89c31f6814a49a2697259ffe57e480e6653d31ee

Comment by Peter Jones [ 19/Apr/17 ]

Landed for 2.10

Generated at Sat Feb 10 02:23:49 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.